这是indexloc提供的服务，不要输入任何密码
Skip to content

metadata should be backwards compatible for remote schemas (fix #1120) #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 27, 2018
Merged

metadata should be backwards compatible for remote schemas (fix #1120) #1121

merged 5 commits into from
Nov 27, 2018

Conversation

@ecthiender
Copy link
Contributor

@ecthiender ecthiender commented Nov 27, 2018

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#1120

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@ecthiender ecthiender requested a review from 0x777 November 27, 2018 05:28
@ecthiender ecthiender added the c/server Related to server label Nov 27, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 27, 2018

Review app for commit b65a2c4 deployed to Heroku: https://hge-ci-pull-1121.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1121-b65a2c4

0x777
0x777 previously approved these changes Nov 27, 2018
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 27, 2018

Review app for commit 02bc147 deployed to Heroku: https://hge-ci-pull-1121.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1121-02bc147

@shahidhk
Copy link
Member

shahidhk commented Nov 27, 2018

Should we also add some tests for these?

@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 27, 2018

Review app for commit 4c03259 deployed to Heroku: https://hge-ci-pull-1121.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1121-4c03259

@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 27, 2018

Review app for commit fbb15e4 deployed to Heroku: https://hge-ci-pull-1121.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1121-fbb15e4

@0x777 0x777 merged commit 0d14c13 into hasura:master Nov 27, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 27, 2018

Review app https://hge-ci-pull-1121.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

Assignees

No one assigned

Labels

c/server Related to server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ecthiender @hasura-bot @shahidhk @0x777