remove dependency on first,last aggregates #1089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Review app available at: https://hge-ci-pull-1089.herokuapp.com |
rakeshkky
approved these changes
Nov 27, 2018
Contributor
|
Review app for commit b818238 deployed to Heroku: https://hge-ci-pull-1089.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-1089.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
<!-- The PR description should answer 2 important questions: --> ### What WIP PoC of a dynamic router for json api. There is no actual execution. This only implements a dynamic router, which can validate any path/URL against the metadata. The `json_api` module exports an `axum::Router` which is added to the main router. It is currently hidden behind an unstable feature flag `--enable-json-api`. Added some clippy allow annotations as its WIP. ### How Create an axum router which matches on any path. And then inside the handler check and validate with an own internal state if the route is valid. This internal state is derived from metadata and is built during start-up. V3_GIT_ORIGIN_REV_ID: b2ee0a3419bd9292af9acf1787381099d20da2ab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We used to depend on
firstaggregation in the generated SQL queries. This dependency has been removed a while ago, however we haven't removed the dependency in an internal view that we use. This PR completely gets rid of the dependency onfirstaggregates.What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
#1085
Solution and Design
Type
Checklist: