server: fix action sync websocket test #10730
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
|
|
Contributor
|
Thanks for raising this pull request @emmanuel-ferdman! 🙏 |
paritosh-08
approved these changes
Jun 10, 2025
hasura-bot
added a commit
that referenced
this pull request
Sep 10, 2025
GITHUB_PR_NUMBER: 10730 GITHUB_PR_URL: #10730 PR-URL: hasura/graphql-engine-mono#11260 Co-authored-by: Emmanuel Ferdman <35470921+emmanuel-ferdman@users.noreply.github.com> GitOrigin-RevId: 5a0d43817602ba3155b20bbef497f16436411dd3
Collaborator
|
Thanks for noticing this, and sorry it fell through the cracks! This has been merged |
hasura-bot
added a commit
that referenced
this pull request
Oct 1, 2025
GITHUB_PR_NUMBER: 10730 GITHUB_PR_URL: #10730 PR-URL: hasura/graphql-engine-mono#11260 Co-authored-by: Emmanuel Ferdman <35470921+emmanuel-ferdman@users.noreply.github.com> GitOrigin-RevId: 11b49ee704805e5eb337cb9dbdf300c680cc0c3a
hasura-bot
added a commit
that referenced
this pull request
Nov 17, 2025
* ci: tag release v2.48.0 PR-URL: hasura/graphql-engine-mono#11232 * ci: automatically add appropriate labels to PRs into release branches… … (attempt 1) I anticipate needing to iterate on this a few times PR-URL: hasura/graphql-engine-mono#11235 * ci: add auto-update-auto-merge to tags in #11235 PR-URL: hasura/graphql-engine-mono#11240 * ci: Add auto-approve label for ceremonial release PRs PR-URL: hasura/graphql-engine-mono#11251 * ci: tag release v2.36.13 PR-URL: hasura/graphql-engine-mono#11256 * ci: Add missing labels to catalog version PRs automatically The release script will automatically wait for this special PR to be merged. Adding these means the user just has to intervene with one button click. PR-URL: hasura/graphql-engine-mono#11261 * server/cloud: try to work around mkAutoUpdate errors PR-URL: hasura/graphql-engine-mono#11255 * ci: fix up erroneous catalog version in main PR-URL: hasura/graphql-engine-mono#11262 * ci: tag release v2.48.0 PR-URL: hasura/graphql-engine-mono#11263 * Console: Fix OpenAPI spec export for REST endpoints with GET operations and query variables PR-URL: hasura/graphql-engine-mono#11258 * Snowflake: fix self-referential relationships PR-URL: hasura/graphql-engine-mono#11267 * ci: tag release v2.48.1 PR-URL: hasura/graphql-engine-mono#11269 * ENG-1768: ignore unknown key types when parsing JWK set json PR-URL: hasura/graphql-engine-mono#11273 * Update the base images of the graphql-engine docker images PR-URL: hasura/graphql-engine-mono#11274 * ci: tag release v2.36.14 PR-URL: hasura/graphql-engine-mono#11276 * ci/scripts: add a helper script for automating releases (ENG-1732) PR-URL: hasura/graphql-engine-mono#11272 * ci: tag release v2.36.10-1 PR-URL: hasura/graphql-engine-mono#11279 * Add AGGREGATION_FUNCTION to RestRoutineType for BQ PR-URL: hasura/graphql-engine-mono#11281 * Add metric hasura_metadata_inconsistencies PR-URL: hasura/graphql-engine-mono#11282 * ci: exclude scripts/release folder while migrating PR-URL: hasura/graphql-engine-mono#11284 * scan images using Gokakashi PR-URL: hasura/graphql-engine-mono#11266 * CI: Update create-docs-ticket.yml PR-URL: hasura/graphql-engine-mono#11286 * Chore: Update CI PR-URL: hasura/graphql-engine-mono#11288 * Update packaging images PR-URL: hasura/graphql-engine-mono#11289 * ci: tag release v2.36.10-2 PR-URL: hasura/graphql-engine-mono#11291 * ENG-1822: filter empty subscription result rows in database query, fo… PR-URL: hasura/graphql-engine-mono#11295 * Prisma Postgres added to postgres databases section GITHUB_PR_NUMBER: 10746 GITHUB_PR_URL: #10746 PR-URL: hasura/graphql-engine-mono#11294 Co-authored-by: Aidan McAlister <105178005+aidankmcalister@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix(console): Remote schema modification fails when schema name contains spaces PR-URL: hasura/graphql-engine-mono#11298 * ENG-1800: tests * ENG-1800: Preserve upstream descriptions while building remote schema permissions schema This commit mostly authored by Rakesh * ENG-1800: Take remote field from remote type description * server: in cockroach backend return NULL for descriptions, not '' This maintains consistency with postgres and allows the logic for propogating descriptions from remote to combined schema to work properly. * ci: tag release v2.48.2 PR-URL: hasura/graphql-engine-mono#11302 * ci: tag release v2.48.3 PR-URL: hasura/graphql-engine-mono#11305 * Revert "Console: Fix OpenAPI spec export for REST endpoints with GET operations and query variables" This reverts commit 0b040f6b4072ad2cba8054914e9322ee1a11f27f. This needs to be fixed in the server. * CON-336: fix invalid OpenAPI specs re. paramaters, for REST-ified endpoints The swagger validator flags two issues: - the presence of 'responseBody' sections in GET paths - parameters `in: path` not marked as required * console: fix a confusing docs message * ci: update latest stable release as v2.48.3 PR-URL: hasura/graphql-engine-mono#11307 * ENG-1844: Support non-array results with remove_empty_subscription_re… PR-URL: hasura/graphql-engine-mono#11309 * ENG-1853: add super-connector snowflake JAVA_OPTS PR-URL: hasura/graphql-engine-mono#11310 Co-authored-by: Gavin Ray <26604994+GavinRay97@users.noreply.github.com> * dev.sh: support setting pg and engine port from environment PR-URL: hasura/graphql-engine-mono#11312 * ci: tag release v2.48.4 PR-URL: hasura/graphql-engine-mono#11314 * ci: update latest stable release as v2.48.4 PR-URL: hasura/graphql-engine-mono#11316 * Revert "ci: update latest stable release as v2.48.4" Reverts hasura/graphql-engine-mono#11316 This wasn't published yet, it seems #10768 PR-URL: hasura/graphql-engine-mono#11318 * ENG-1854: redact potentially-sensitive headers from event-trigger logs PR-URL: hasura/graphql-engine-mono#11321 * Jberryman/10768 dont merge post release stuff until release published To prevent #10768 from merging the final post-release PR to early. Tested on this PR and then cleaned up. It's not expected to run here, only on cli/get.sh change PR-URL: hasura/graphql-engine-mono#11322 * ci: update latest stable release as v2.48.4 Originally merged and reverted since release hadn't completed: c2f657b9cef6403bd98c1ffafa21a5de55d15cf2 d519dbef32caa25df835f7b599fe3b79c5b1ce70 PR-URL: hasura/graphql-engine-mono#11323 * ci: scan lts images PR-URL: hasura/graphql-engine-mono#11324 * Docs: Add RSA key-pair auth for Snowflake PR-URL: hasura/graphql-engine-mono#11326 * server: don't filter out JWKs without a 'use' field PR-URL: hasura/graphql-engine-mono#11329 * Try to detect when we have missing commits in cut-minor-release.sh wh… PR-URL: hasura/graphql-engine-mono#11330 * ci: tag release v2.48.5 PR-URL: hasura/graphql-engine-mono#11332 * server: fix action sync websocket test GITHUB_PR_NUMBER: 10730 GITHUB_PR_URL: #10730 PR-URL: hasura/graphql-engine-mono#11260 Co-authored-by: Emmanuel Ferdman <35470921+emmanuel-ferdman@users.noreply.github.com> * ci: update latest stable release as v2.48.5 (MERGE ONCE RELEASED) PR-URL: hasura/graphql-engine-mono#11334 * ci: update image scan logic PR-URL: hasura/graphql-engine-mono#11325 * server: test and ship support for postgres 17 * server: upgrade to ghc 9.10.2 For some reason the 9.10.1 fork we built is no longer installing. Maybe it was deleted. I verified 9.10.2 should have the patches that were the reason for the fork. * ENG-1888: Fix skipped rows in streaming subscriptions for postgres an… PR-URL: hasura/graphql-engine-mono#11336 * ENG-1823: Fix prefixed remote schema types getting intermixed PR-URL: hasura/graphql-engine-mono#11337 * ci: tag release v2.48.6 PR-URL: hasura/graphql-engine-mono#11340 * switch from deprecated haskell github action PR-URL: hasura/graphql-engine-mono#11343 * ci: add product domain and repo associations in image scans PR-URL: hasura/graphql-engine-mono#11339 * server: fix for erroneous duplicate functions due to oid overlap PR-URL: hasura/graphql-engine-mono#11345 * ci: update latest stable release as v2.48.6 Will open once release is live PR-URL: hasura/graphql-engine-mono#11342 * server: record latency metrics on failure too PR-URL: hasura/graphql-engine-mono#11346 * Console: Include referenced enum types in remote schema permissions SDL PR-URL: hasura/graphql-engine-mono#11347 * docs: remove banners for ddn PR-URL: hasura/graphql-engine-mono#11352 * auth-hook, caching: ignore tracing related headers PR-URL: hasura/graphql-engine-mono#11350 * ci: tag release v2.48.7 PR-URL: hasura/graphql-engine-mono#11355 * Remove remaining Gokashi stuff, after merging main * ci: release v2.48.7 * ci: release v2.48.7-ce * ci: release v2.48.7-cloud.1 --------- Co-authored-by: Daniel Harvey <danieljamesharvey@gmail.com> Co-authored-by: Varun Choudhary <68095256+Varun-Choudhary@users.noreply.github.com> Co-authored-by: Gavin Ray <ray.gavin97@gmail.com> Co-authored-by: Karthikeyan Chinnakonda <karthikeyan@hasura.io> Co-authored-by: Brandon Martin <brandon@codedmart.com> Co-authored-by: nizar-m <19857260+nizar-m@users.noreply.github.com> Co-authored-by: Vishnu Bharathi <vishnubharathi04@gmail.com> Co-authored-by: paritosh-08 <85472423+paritosh-08@users.noreply.github.com> Co-authored-by: Rob Dominguez <rob.dominguez@hasura.io> Co-authored-by: hasura-bot <accounts@hasura.io> Co-authored-by: Aidan McAlister <105178005+aidankmcalister@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Rakesh <12475069+rakeshkky@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Gavin Ray <26604994+GavinRay97@users.noreply.github.com> Co-authored-by: Emmanuel Ferdman <35470921+emmanuel-ferdman@users.noreply.github.com> GitOrigin-RevId: edec677fc4607c820ce92dee9a641df4cc552f71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolved duplicate test function names in the websocket action test suite by renaming conflicting test cases to maintain clear distinction between success and failure scenarios.
Changelog
Component: server
Type: bugfix
Product: community-edition
Short Changelog
Fixed test naming conflicts in action test suite.
Long Changelog
Related Issues
Solution and Design
Steps to test and verify
Limitations, known bugs & workarounds
None - this change only affects test naming.
Server checklist
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
GraphQL
Breaking changes