这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix Native query placeholders in the console (close #10727) #10728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Native query placeholders in the console (close #10727) #10728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2761d35
Fix native query placeholders
bokub May 5, 2025
bdd1fb5
Update AddNativeQuery.stories.tsx
bokub May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...e/legacy-ce/src/lib/features/Data/LogicalModels/AddNativeQuery/AddNativeQuery.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@ const fillAndSubmitForm: Story['play'] = async (
//await userEvent.click(c.getAllByText('Remove')[0]);

await userEvent.type(
c.getByPlaceholderText('Name that exposes this model in GraphQL API'),
c.getByPlaceholderText('Name that exposes this query in GraphQL API'),
'my_native_query'
);
await userEvent.type(
c.getByPlaceholderText('A description of this logical model'),
c.getByPlaceholderText('A description of this native query'),
'a description'
);

Expand Down
4 changes: 2 additions & 2 deletions .../src/lib/features/Data/LogicalModels/AddNativeQuery/components/NativeQueryDetailsForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,13 @@ export const NativeQueryFormFields = ({ sources }: { sources?: Source[] }) => {
<GraphQLSanitizedInputField
name="root_field_name"
label="Native Query Name"
placeholder="Name that exposes this model in GraphQL API"
placeholder="Name that exposes this query in GraphQL API"
hideTips
/>
<InputField
name="comment"
label="Comment"
placeholder="A description of this logical model"
placeholder="A description of this native query"
/>
<Select
name="source"
Expand Down