handle input empty array for _in and _nin operators, fix #1075 #1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Review app available at: https://hge-ci-pull-1076.herokuapp.com |
0x777
approved these changes
Nov 21, 2018
Contributor
|
Review app https://hge-ci-pull-1076.herokuapp.com is deleted |
|
_nin is returning values, I want to only return the fields that does no contain what is mentioned inside of the json that equals _nin. so if my jsonb has ["taco"] and I want to exclude all results that mention ["taco"] in that jsonb, I use _nin, but _nin is returning results all results ["taco"] and ones without ["taco"]. and then when I try the opposite using _in all the results are gone, even the ones that do not contain ["taco"], so it is an empty query return or [] that is returned, it hides all results the ones that do not contain ["taco"] and ones that do when using _in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
fix #1075
Solution and Design
For
_inoperator ifempty arrayis given then consider it asfalse.Vice versa for
_ninoperator.Type
Checklist: