fix sql generation for boolean expressions #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
November 9, 2018 18:30
Contributor
|
Review app available at: https://hge-ci-pull-1037.herokuapp.com |
Contributor
|
Review app available at: https://hge-ci-pull-1037.herokuapp.com |
rakeshkky
previously approved these changes
Nov 16, 2018
Contributor
|
Review app available at: https://hge-ci-pull-1037.herokuapp.com |
Contributor
|
Review app available at: https://hge-ci-pull-1037.herokuapp.com |
Contributor
|
Review app available at: https://hge-ci-pull-1037.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-1037.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
<!-- The PR description should answer 2 important questions: --> ### What Exposes SQL constraints to datafusion's planner via the `TableProvider::constraints()` trait method. ### How We pull these constraints from the GraphQL configuration for the model. This is not ideal - the data should really live at the model layer now. But we can hopefully solve that later. <!-- How is it trying to accomplish it (what are the implementation steps)? --> V3_GIT_ORIGIN_REV_ID: c723d895fd707e24defae971f474b5938478a82b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unique aliases are generated for the tablenames of relationships used in the boolean expression. Required a major rewrite of internals.
Description
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
#853
Solution and Design
Type
Checklist: