这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@rakeshkky
Copy link
Member

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

fix #1004

Solution and Design

Do not prepend column identifiers with prefix in aggregate object selection.

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@rakeshkky rakeshkky requested a review from 0x777 November 9, 2018 15:58
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-1005.herokuapp.com

@shahidhk shahidhk added the c/server Related to server label Nov 12, 2018
@0x777 0x777 merged commit 80de0e0 into hasura:master Nov 12, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1005.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/server Related to server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

do not add prefixes for column identifiers in aggregate selection

4 participants