这是indexloc提供的服务，不要输入任何密码
Skip to content

track table when 'create or replace' is used in run sql (close #995) #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2018
Merged

track table when 'create or replace' is used in run sql (close #995) #1021

merged 2 commits into from
Nov 13, 2018

Conversation

@arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented Nov 13, 2018

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#995

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@arvi3411301 arvi3411301 added s/do-not-merge Do not merge this pull request to master c/console Related to console labels Nov 13, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 13, 2018

Review app available at: https://hge-ci-pull-1021.herokuapp.com

@praveenweb praveenweb added s/ok-to-merge Status: This pull request can be merged to master and removed s/do-not-merge Do not merge this pull request to master labels Nov 13, 2018
@shahidhk shahidhk changed the title fixes create or replace view syntax doesn't create track table (close #995) track table when 'create or replace' is used in run sql (close #995) Nov 13, 2018
shahidhk
shahidhk approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@shahidhk shahidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahidhk shahidhk merged commit 03d2ebd into hasura:master Nov 13, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 13, 2018

Review app https://hge-ci-pull-1021.herokuapp.com is deleted

@arvi3411301 arvi3411301 deleted the issue-995 branch January 3, 2019 11:01
This was referenced Oct 25, 2023
Open
Open
hasura-bot pushed a commit that referenced this pull request Aug 28, 2024
@paf31 @hasura-bot
[PACHA-25] Aggregate pushdown for COUNT (#1021)
06937b1 
<!-- The PR description should answer 2 important questions: -->

### What

Push down SQL `COUNT` aggregates to the NDC layer:

- `COUNT(1)`
- `COUNT(col)` where col may be nested
- `COUNT(DISTINCT col)`

### How

Introduces a new logical node (`ModelAggregate`) and corresponding
physical node (`NDCAggregatePushdown`). Whenever we see a `ModelQuery`
wrapped in an `Aggregate` node, we rewrite it to a `ModelAggregate` node
instead. We don't handle `GROUP BY` yet, but this approach will
generalize to that once NDC 0.2.0 lands.

V3_GIT_ORIGIN_REV_ID: 373d3941fc01c077270047612240d910045f6d93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

@praveenweb praveenweb praveenweb approved these changes

Assignees

No one assigned

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arvi3411301 @hasura-bot @shahidhk @praveenweb