这是indexloc提供的服务，不要输入任何密码
Skip to content

[WIP] Add: View in voyager function #314 #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 30 commits into from
Closed

[WIP] Add: View in voyager function #314 #799

wants to merge 30 commits into from

Conversation

@vshelke
Copy link

@vshelke vshelke commented Oct 17, 2018 •
edited
Loading

Description

Added a new VoyagerView component to view the schema using graphql-voyager

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Console
  • Server
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

proposal for #314

Solution and Design

A new React.Component is added which renders within the App context and opens in a new tab.

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 17, 2018

Beep boop! 🤖

Hey @vshelke, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible. 🕐

Stay awesome! 😎

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 17, 2018

Review app available at: https://hge-ci-pull-799.herokuapp.com

1 similar comment
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 17, 2018

Review app available at: https://hge-ci-pull-799.herokuapp.com

@dsandip
Copy link
Member

dsandip commented Oct 17, 2018 •
edited
Loading

Hey @vshelke, this looks promising! The right place for the Voyager button is in the /console/data/schema/* pages (in the left nav bar; with a separator grey line after SQL):

voyager button placement

Also, good to have but definitely not necessary for the first version would be to have the visualization zoom into the table's position in the schema if you are on a /console/data/schema/<schema-name>/<table-name>/browse page. E.g. Navigating to https://hge-ci-pull-799.herokuapp.com/console/data/schema/public/tables/Person/browse and then opening Voyager should open the following (with the aforementioned zoom):

screen shot 2018-10-17 at 4 34 42 pm

@praveenweb @rikinsk

@shahidhk shahidhk added c/console Related to console hacktoberfest labels Oct 17, 2018
@dsandip dsandip added the s/do-not-merge Do not merge this pull request to master label Oct 17, 2018
@vshelke
Copy link
Author

vshelke commented Oct 17, 2018

Okay, will soon come up with required changes. Thank you @dsandip

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 18, 2018

Review app available at: https://hge-ci-pull-799.herokuapp.com

@vshelke
Copy link
Author

vshelke commented Oct 22, 2018 •
edited
Loading

The recent commit includes the required updates with the visualisation of zoom into tables position in the schema and also fixed the test.
Sorry for the late update on this issue. You can review the code to move further with this issue. @shahidhk

@arvi3411301
Copy link
Member

arvi3411301 commented Oct 23, 2018

/heroku deploy

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 23, 2018

Review app available at: https://hge-ci-pull-799.herokuapp.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 24, 2018

Review app available at: https://hge-ci-pull-799.herokuapp.com

1 similar comment
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 24, 2018

Review app available at: https://hge-ci-pull-799.herokuapp.com

@vshelke
Copy link
Author

vshelke commented Oct 24, 2018

/heroku deploy

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 24, 2018

@vshelke you don't have enough permissions to execute this command

@mnlbox
Copy link
Contributor

mnlbox commented Jan 24, 2019

@vshelke Wooooooooooooo It's awesome. Any plan to merge this soon?

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 24, 2019

Review app for commit 6b65d73 deployed to Heroku: https://hge-ci-pull-799.herokuapp.com
Docker image for server: hasura/graphql-engine:pull799-6b65d73

@mnlbox
Copy link
Contributor

mnlbox commented Jan 24, 2019

@praveenweb It shows: Something went wrong.

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 25, 2019

Review app for commit 421165f deployed to Heroku: https://hge-ci-pull-799.herokuapp.com
Docker image for server: hasura/graphql-engine:pull799-421165f

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 28, 2019

Review app for commit f613494 deployed to Heroku: https://hge-ci-pull-799.herokuapp.com
Docker image for server: hasura/graphql-engine:pull799-f613494

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 31, 2019

Review app for commit aeaab72 deployed to Heroku: https://hge-ci-pull-799.herokuapp.com
Docker image for server: hasura/graphql-engine:pull799-aeaab72

@vshelke
Copy link
Author

vshelke commented Jan 31, 2019

@mnlbox The current feature has issues with the viewport. I have fixed the Something went wrong. issue.

@mnlbox
Copy link
Contributor

mnlbox commented Feb 13, 2019

Guys is it ready for merge?

@mnlbox mnlbox mentioned this pull request Mar 12, 2019
Closed
@mnlbox mnlbox mentioned this pull request Apr 18, 2019
Closed
@mnlbox mnlbox mentioned this pull request May 7, 2019
Closed
@FluorescentHallucinogen
Copy link

FluorescentHallucinogen commented May 7, 2019

Any progress?

@praveenweb praveenweb requested a review from rikinsk-zz as a code owner May 12, 2019 10:51
@netlify
Copy link

netlify bot commented May 12, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit f54d5eb

https://deploy-preview-799--hasura-docs.netlify.com

@vshelke vshelke requested a review from shahidhk as a code owner May 12, 2019 11:34
@praveenweb praveenweb mentioned this pull request May 12, 2019
Closed
2 tasks
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 18, 2019

Review app https://hge-ci-pull-799.herokuapp.com is deleted

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 25, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 40de5f2
Status:⚡️  Build in progress...

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb Awaiting requested review from praveenweb

@rikinsk-zz rikinsk-zz Awaiting requested review from rikinsk-zz

@shahidhk shahidhk Awaiting requested review from shahidhk

Assignees

No one assigned

Labels

c/console Related to console s/do-not-merge Do not merge this pull request to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@vshelke @CLAassistant @hasura-bot @dsandip @arvi3411301 @ecthiender @shahidhk @praveenweb @mnlbox @FluorescentHallucinogen