这是indexloc提供的服务，不要输入任何密码
Skip to content

fix a typo #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2018
Merged

fix a typo #788

merged 1 commit into from
Oct 20, 2018

Conversation

@epicalyx
Copy link
Contributor

@epicalyx epicalyx commented Oct 16, 2018

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 16, 2018

Review app available at: https://hge-ci-pull-788.herokuapp.com

@shahidhk shahidhk added the c/cli Related to CLI label Oct 20, 2018
@shahidhk shahidhk merged commit 2127ae8 into hasura:master Oct 20, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 20, 2018

Review app https://hge-ci-pull-788.herokuapp.com is deleted

@shahidhk shahidhk mentioned this pull request Oct 20, 2018
Closed
21 tasks
hasura-bot pushed a commit that referenced this pull request Jul 1, 2024
@rakeshkky @hasura-bot
Unify get_underlying_type_name and get_base_type functions (#788)
5efbb09 
### What
This is a no-op refactor that involves unifying `get_base_type` and
`get_underlying_type_name` functions, whose motives are the same.

### How
Replace the name of erstwhile `get_base_type` fn with
`get_underlying_type_name`. Remove the latter. Update the rest of the
code to use the new function.

V3_GIT_ORIGIN_REV_ID: 0b0d999670641ba265fde153af9b43b4d865e215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

Assignees

No one assigned

Labels

c/cli Related to CLI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@epicalyx @hasura-bot @shahidhk