这是indexloc提供的服务，不要输入任何密码
Skip to content

for views consider only insertable ones in generating nested insert input objects (fix #773) #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2018
Merged

for views consider only insertable ones in generating nested insert input objects (fix #773) #774

merged 2 commits into from
Oct 16, 2018

Conversation

@rakeshkky
Copy link
Member

@rakeshkky rakeshkky commented Oct 16, 2018

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

fix #773

Solution and Design

Consider only insertable views in generating RelationInfoMap of InsCtx of a table.

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@rakeshkky rakeshkky added s/ok-to-merge Status: This pull request can be merged to master c/server Related to server e/quickfix can be wrapped up in few hours labels Oct 16, 2018
@rakeshkky rakeshkky self-assigned this Oct 16, 2018
@rakeshkky rakeshkky requested a review from 0x777 October 16, 2018 08:39
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 16, 2018

Review app available at: https://hge-ci-pull-774.herokuapp.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 16, 2018

Review app available at: https://hge-ci-pull-774.herokuapp.com

@shahidhk shahidhk merged commit 45691e3 into hasura:master Oct 16, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 16, 2018

Review app https://hge-ci-pull-774.herokuapp.com is deleted

@corysimmons
Copy link

corysimmons commented Oct 16, 2018

This is why I love you guys. :)

@snyk-bot snyk-bot mentioned this pull request Oct 13, 2022
Merged
hasura-bot pushed a commit that referenced this pull request Jun 27, 2024
@danieljharvey @hasura-bot
Split up command resolve stage (#774)
9232af9 
<!-- The PR description should answer 2 (maybe 3) important questions:
-->

### What

Tiny no-op PR to split the `command` stage of `metadata-resolve` into
smaller modules the same way `models` and others work.

<!-- What is this PR trying to accomplish (and why, if it's not
obvious)? -->

<!-- Consider: do we need to add a changelog entry? -->

### How

Copy and paste, run `just fix-local` to remove unrequired imports.

<!-- How is it trying to accomplish it (what are the implementation
steps)? -->

V3_GIT_ORIGIN_REV_ID: ab2846be83ba0e948ea222b42eb4fd7ffa5b3523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

Assignees

@rakeshkky rakeshkky

Labels

c/server Related to server e/quickfix can be wrapped up in few hours s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

for views consider only insertable ones in nested insert input objects

5 participants

@rakeshkky @hasura-bot @corysimmons @0x777 @shahidhk