这是indexloc提供的服务，不要输入任何密码
Skip to content

send 'completed' after an error when handling start in ws (close #671) #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2018
Merged

send 'completed' after an error when handling start in ws (close #671) #776

merged 2 commits into from
Oct 16, 2018

Conversation

@0x777
Copy link
Member

@0x777 0x777 commented Oct 16, 2018 •
edited
Loading

Description

In subscription protocol, completed message is now sent after errors.

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#671

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@0x777 0x777 mentioned this pull request Oct 16, 2018
Closed
21 tasks
@0x777 0x777 requested a review from rakeshkky October 16, 2018 10:23
@0x777
Copy link
Member Author

0x777 commented Oct 16, 2018

@wawhal Once the build finishes, can you check if this resolves #671?

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 16, 2018

Review app available at: https://hge-ci-pull-776.herokuapp.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 16, 2018

Review app available at: https://hge-ci-pull-776.herokuapp.com

@shahidhk shahidhk changed the title send 'completed' after an error when handling start, closes #671 send 'completed' after an error when handling start (close #671) Oct 16, 2018
@shahidhk shahidhk changed the title send 'completed' after an error when handling start (close #671) send 'completed' after an error when handling start in ws (close #671) Oct 16, 2018
@shahidhk shahidhk merged commit 67168b3 into hasura:master Oct 16, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 16, 2018

Review app https://hge-ci-pull-776.herokuapp.com is deleted

@shahidhk shahidhk added the c/server Related to server label Oct 16, 2018
@snyk-bot snyk-bot mentioned this pull request Oct 13, 2022
Merged
hasura-bot pushed a commit that referenced this pull request Jun 27, 2024
@plcplc @danieljharvey @hasura-bot
Stdout otel exporter (#776)
0ea629a 
### What

Output all traces to stdout.

---------

Co-authored-by: Daniel Harvey <danieljamesharvey@gmail.com>
V3_GIT_ORIGIN_REV_ID: 06330076ca305a331996530ddcd4d4c13d46bd95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rakeshkky rakeshkky rakeshkky approved these changes

Assignees

No one assigned

Labels

c/server Related to server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@0x777 @hasura-bot @rakeshkky @shahidhk