这是indexloc提供的服务，不要输入任何密码
Skip to content

send 'completed' after an error when handling start, closes #671 #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

send 'completed' after an error when handling start, closes #671 #757

wants to merge 1 commit into from

Conversation

@0x777
Copy link
Member

@0x777 0x777 commented Oct 15, 2018

Description

In subscription protocol, completed message is now sent after errors.

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#671

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

jasonmuldoon
jasonmuldoon approved these changes Oct 16, 2018
View reviewed changes
Copy link

@jasonmuldoon jasonmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice very impressive

@shahidhk shahidhk requested a review from rakeshkky October 16, 2018 06:37
@shahidhk shahidhk added the c/server Related to server label Oct 16, 2018
@0x777
Copy link
Member Author

0x777 commented Oct 16, 2018

closing this in favor of #776

@0x777 0x777 closed this Oct 16, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 16, 2018

Review app https://hge-ci-pull-757.herokuapp.com is deleted

@0x777 0x777 deleted the issue-671 branch October 16, 2018 10:30
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 27, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3df2403
Status:⚡️  Build in progress...

View logs

hasura-bot pushed a commit that referenced this pull request Jun 25, 2024
@i-am-tom @hasura-bot
Stop hiding the GraphqlConfig subgraph object (#757)
d49f4ac 
### What

I'm not sure why this is still hidden, but it shouldn't be.

### How

We remove the flag.

V3_GIT_ORIGIN_REV_ID: 4a73e380e0daebe3370a6561bcd4056a9013410a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rakeshkky rakeshkky Awaiting requested review from rakeshkky

1 more reviewer

@jasonmuldoon jasonmuldoon jasonmuldoon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/server Related to server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@0x777 @hasura-bot @jasonmuldoon @shahidhk