这是indexloc提供的服务，不要输入任何密码
Skip to content

fix track table error when table name is immediately followed by '(' (close #717) #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2018
Merged

fix track table error when table name is immediately followed by '(' (close #717) #718

merged 1 commit into from
Oct 15, 2018

Conversation

@arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented Oct 12, 2018

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@arvi3411301 arvi3411301 added s/do-not-merge Do not merge this pull request to master c/console Related to console labels Oct 12, 2018
@CLAassistant
Copy link

CLAassistant commented Oct 12, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 12, 2018

Review app available at: https://hge-ci-pull-718.herokuapp.com

@coco98
Copy link
Contributor

coco98 commented Oct 12, 2018 •
edited
Loading

@arvi3411301 Can you please write a description of how you fixed the issue? It will help folks learn what the approach is and also spot edge cases if any.

EDIT: in this case it's just a change to a regex so I guess that's ok. I guess you can just comment saying that you've changed the regex :)

@shahidhk shahidhk changed the title fix track table with run sql query fails if the table name is immediately followed by (, close #717 fix track table error when table name is immediately followed by '(' (close #717) Oct 15, 2018
@shahidhk shahidhk merged commit 6591095 into hasura:master Oct 15, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 15, 2018

Review app https://hge-ci-pull-718.herokuapp.com is deleted

@shahidhk shahidhk removed the s/do-not-merge Do not merge this pull request to master label Oct 15, 2018
hasura-bot pushed a commit that referenced this pull request Jun 17, 2024
@dependabot @hasura-bot
Bump diffy from 0.3.0 to 0.4.0 (#718)
756ca36 
Bumps [diffy](https://github.com/bmwill/diffy) from 0.3.0 to 0.4.0.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
V3_GIT_ORIGIN_REV_ID: a8d610058bfb0f0fd7af547882724457202c25f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

Assignees

No one assigned

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@arvi3411301 @CLAassistant @hasura-bot @coco98 @praveenweb @shahidhk