这是indexloc提供的服务，不要输入任何密码
Skip to content

fix input object validation logic (fix #693) #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2018
Merged

fix input object validation logic (fix #693) #711

merged 2 commits into from
Oct 12, 2018

Conversation

@rakeshkky
Copy link
Member

@rakeshkky rakeshkky commented Oct 12, 2018 •
edited
Loading

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

fix #693

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • [ x I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have modified required tests.

@rakeshkky rakeshkky added s/ok-to-merge Status: This pull request can be merged to master c/server Related to server e/quickfix can be wrapped up in few hours labels Oct 12, 2018
@rakeshkky rakeshkky self-assigned this Oct 12, 2018
@rakeshkky rakeshkky requested a review from 0x777 October 12, 2018 08:23
@0x777 0x777 changed the title fix validate input object logic fix input object validation logic Oct 12, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 12, 2018

Review app available at: https://hge-ci-pull-711.herokuapp.com

@0x777
Copy link
Member

0x777 commented Oct 12, 2018

@rakeshkky can you add a test case with mutations permissions without select?

@0x777
Copy link
Member

0x777 commented Oct 12, 2018

@rakeshkky see #701

@rakeshkky rakeshkky changed the title fix input object validation logic fix input object validation logic (fix #693) Oct 12, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 12, 2018

Review app available at: https://hge-ci-pull-711.herokuapp.com

@shahidhk shahidhk merged commit 37e848c into hasura:master Oct 12, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 12, 2018

Review app https://hge-ci-pull-711.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Jun 24, 2024
@danieljharvey @hasura-bot
Ban println! in code with clippy (#711)
eba7969 
<!-- Thank you for submitting this PR! :) -->

## Description

A few debug lines slipped in recently, let's make `clippy` `warn` on
those, so they are kicked out by CI. Functional no-op.

V3_GIT_ORIGIN_REV_ID: 290f6de35f9315b68811eb5f15969fb0333e9d06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

Assignees

@rakeshkky rakeshkky

Labels

c/server Related to server e/quickfix can be wrapped up in few hours s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unexpected keys in input values aren't validated

4 participants

@rakeshkky @hasura-bot @0x777 @shahidhk