workaround postgres default limit of 63 chars for identifiers (close #688) #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rakeshkky
previously approved these changes
Oct 11, 2018
Member
|
@0x777 @rakeshkky Shouldn't we add a few test-cases for this? |
shahidhk
approved these changes
Oct 12, 2018
Contributor
|
Review app https://hge-ci-pull-707.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Jun 25, 2024
## Description According to NDC headers pass-through spec, commands can include headers in their responses, which are forwarded as response headers by the engine to the client. This PR implements it. V3_GIT_ORIGIN_REV_ID: 4fe458db02c5dd51f4674e4e013312f8e179c087
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Postgres (with default setting) limits the length of an identifier to 63 characters (to be precise it ignores anything beyond 63 characters). Given that we generate readable aliases for queries (which could potentially exceed 63 characters because of nesting) since alpha23 sometimes this results in a postgres query error.
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
#688
Solution and Design
A new
Rewritemodule traverses the generated SQL AST and prefixes each alias with an integer. Even if Postgres ignores anything beyond 63 characters, the uniqueness of the alias is guaranteed by the prefixed integer.Type
Checklist: