这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@carlpaten-ivadolabs
Copy link
Contributor

Description

Enables the use of Hasura server with custom URI schemes, necessary for e.g. Capacitor.

This is a resubmit of #5940 whose CI went bonkers. Hopefully resubmitting on a new branch fixes it.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • Server

Related Issues

#5818

Solution and Design

Accept any non-empty string not containing a colon as a scheme name.

Steps to test and verify

Configure CORS config with an entry starting in e.g. capacitor://.

Limitations, known bugs & workarounds

This probably gives an atrocious error message if the user forgets the colon in the scheme separator.

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code
    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields
    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

@carlpaten-ivadolabs carlpaten-ivadolabs requested a review from a team as a code owner May 4, 2021 20:00
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @LilRed, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@netlify
Copy link

netlify bot commented May 4, 2021

Deploy preview for hasura-docs ready!

Built with commit 68bf981

https://deploy-preview-6870--hasura-docs.netlify.app

@carlpaten-ivadolabs
Copy link
Contributor Author

Merged in #5940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants