这是indexloc提供的服务，不要输入任何密码
Skip to content

Removed alert box (solve #536) #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Removed alert box (solve #536) #679

wants to merge 1 commit into from

Conversation

@vipulgupta2048
Copy link
Contributor

@vipulgupta2048 vipulgupta2048 commented Oct 8, 2018

  • The alert now comes up only when there is access key involved. I think that would get the job done.

🐣

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 8, 2018

Beep boop! 🤖

Hey @vipulgupta2048, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible. 🕐

Stay awesome! 😎

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 8, 2018

Review app available at: https://hge-ci-pull-679.herokuapp.com

@shahidhk
Copy link
Member

shahidhk commented Oct 9, 2018

@vipulgupta2048 Thanks for your contribution 🙏 😄

However, this issue has already been solved in #588

Feel free take up another issue. Thanks again for your efforts.

@shahidhk shahidhk closed this Oct 9, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 9, 2018

Beep boop! 🤖

Hey @vipulgupta2048!

Sorry that your PR wasn’t merged. 😢

We appreciate your effort and want to reward you with some Hasura swag! 😎

Please do fill out 📝 this form so we can 🚢 them to you.

And do take a look at any of the other open 📂 issues to see if you’d like to take something up! We’re around on Discord & Twitter if you have any questions 😄

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 9, 2018

Review app https://hge-ci-pull-679.herokuapp.com is deleted

@shahidhk shahidhk added the c/console Related to console label Oct 9, 2018
@vipulgupta2048
Copy link
Contributor Author

vipulgupta2048 commented Oct 9, 2018

Sorry for the noise, I should have read the issue completely.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 5, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 91e4831
Status:🚫  Build failed.

View logs

hasura-bot pushed a commit that referenced this pull request Jun 6, 2024
@danieljharvey @hasura-bot
Factor source_data_connector out of relationship (#679)
d090331 
<!-- Thank you for submitting this PR! :) -->

## Description

We'd like not to tie our boolean expressions to one particular data
connector, we were doing this in relationships and had no need to.
Functional no-op.

V3_GIT_ORIGIN_REV_ID: 0af16ad92117a45ac1f424b49d9f13184787f63f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vipulgupta2048 @hasura-bot @CLAassistant @shahidhk