这是indexloc提供的服务，不要输入任何密码
Skip to content

add reset metadata button to settings page (close #515) #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 10, 2018
Merged

add reset metadata button to settings page (close #515) #673

merged 11 commits into from
Oct 10, 2018

Conversation

@paranoidsp
Copy link
Contributor

@paranoidsp paranoidsp commented Oct 8, 2018 •
edited
Loading

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@paranoidsp paranoidsp requested a review from karthikvt26 October 8, 2018 09:15
@paranoidsp
Copy link
Contributor Author

paranoidsp commented Oct 8, 2018 •
edited
Loading

Waiting on a small text change.

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 8, 2018

Review app available at: https://hge-ci-pull-673.herokuapp.com

@shahidhk shahidhk added the c/console Related to console label Oct 8, 2018
karthikvt26
karthikvt26 requested changes Oct 8, 2018
View reviewed changes
console/src/components/Services/Data/Metadata/ResetMetadata.js Outdated
if (response.ok) {
this.setState({ isResetting: false });
this.props.dispatch(
showSuccessNotification('Metadata reset successfully!')
Copy link
Contributor

@karthikvt26 karthikvt26 Oct 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add are you sure pop up as suggested by sandip

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 8, 2018

Review app available at: https://hge-ci-pull-673.herokuapp.com

karthikvt26
karthikvt26 previously requested changes Oct 8, 2018
View reviewed changes
console/src/components/Services/Data/Metadata/ResetMetadata.js Outdated
onClick={e => {
e.preventDefault();
const a = prompt(
'Are you sure you absolutely sure?\n This action cannot be undone. This will permanently reset GraphQL Engine\'s configuration and you will need to start from scratch. Please type "Reset" (in caps, without quotes) to confirm. '
Copy link
Contributor

@karthikvt26 karthikvt26 Oct 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paranoidsp typo?

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 9, 2018

Review app available at: https://hge-ci-pull-673.herokuapp.com

@karthikvt26 karthikvt26 added the s/do-not-merge Do not merge this pull request to master label Oct 9, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 9, 2018

Review app available at: https://hge-ci-pull-673.herokuapp.com

1 similar comment
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 9, 2018

Review app available at: https://hge-ci-pull-673.herokuapp.com

@paranoidsp
Copy link
Contributor Author

paranoidsp commented Oct 9, 2018

@karthikvt26 Fixed both issues, needs review.

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 9, 2018

Review app available at: https://hge-ci-pull-673.herokuapp.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 9, 2018

Review app available at: https://hge-ci-pull-673.herokuapp.com

karthikvt26
karthikvt26 previously approved these changes Oct 9, 2018
View reviewed changes
Copy link
Contributor

@karthikvt26 karthikvt26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @praveenweb

@shahidhk shahidhk removed the s/do-not-merge Do not merge this pull request to master label Oct 10, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 10, 2018

Review app available at: https://hge-ci-pull-673.herokuapp.com

@shahidhk
Copy link
Member

shahidhk commented Oct 10, 2018

If I enter something other than RESET, an error appears with a details button, which on clicking shows this:
image

can we remove the details button?

shahidhk
shahidhk previously requested changes Oct 10, 2018
View reviewed changes
Copy link
Member

@shahidhk shahidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check #673 (comment)

@paranoidsp
Copy link
Contributor Author

paranoidsp commented Oct 10, 2018

@shahidhk @karthikvt26 Fixed, check now?

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 10, 2018

Review app available at: https://hge-ci-pull-673.herokuapp.com

shahidhk
shahidhk approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@shahidhk shahidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahidhk shahidhk merged commit 882719f into hasura:master Oct 10, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 10, 2018

Review app https://hge-ci-pull-673.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Jun 5, 2024
@danieljharvey @hasura-bot
Make very happy path BooleanExpressionType work (#673)
2cd6130 
<!-- Thank you for submitting this PR! :) -->

## Description

This makes the absolute happiest path `BooleanExpressionType` work.

Caveats:

- We ignore operator mappings, so we assume that the OpenDD operator
name (ie, `_eq`) is the same as the data connector's name for it.

- We have not tried to implement `comparisonRelationships` in any way
yet.

- Have not tried nested objects yet.

All functionality here is behind a feature flag so has no user-facing
impact.

V3_GIT_ORIGIN_REV_ID: 5edb706c6d8b03b9fa59433ce24f05f37a69729a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

@karthikvt26 karthikvt26 karthikvt26 left review comments

Assignees

No one assigned

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paranoidsp @hasura-bot @shahidhk @karthikvt26