这是indexloc提供的服务，不要输入任何密码
Skip to content

allow ordering using columns from object relationships (close #463) #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 26, 2018
Merged

allow ordering using columns from object relationships (close #463) #672

merged 14 commits into from
Oct 26, 2018

Conversation

@rakeshkky
Copy link
Member

@rakeshkky rakeshkky commented Oct 8, 2018

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

close #463

Solution and Design

Generate extra enums values like rel_<obj-rel>_<column>_<sort-type> for table_order_by type.

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@rakeshkky rakeshkky requested a review from 0x777 October 8, 2018 08:14
@shahidhk shahidhk added the c/server Related to server label Oct 8, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 8, 2018

Review app available at: https://hge-ci-pull-672.herokuapp.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 8, 2018

Review app available at: https://hge-ci-pull-672.herokuapp.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 9, 2018

Review app available at: https://hge-ci-pull-672.herokuapp.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 9, 2018

Review app available at: https://hge-ci-pull-672.herokuapp.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 9, 2018

Review app available at: https://hge-ci-pull-672.herokuapp.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 10, 2018

Review app available at: https://hge-ci-pull-672.herokuapp.com

@rakeshkky
Merge branch 'master' into issue-463
f393ef5 
Resolve Conflicts:
	server/src-lib/Hasura/GraphQL/Resolve/Insert.hs
	server/src-lib/Hasura/GraphQL/Schema.hs
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 26, 2018

Review app available at: https://hge-ci-pull-672.herokuapp.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 26, 2018

Review app available at: https://hge-ci-pull-672.herokuapp.com

1 similar comment
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 26, 2018

Review app available at: https://hge-ci-pull-672.herokuapp.com

@0x777 0x777 merged commit f6ed169 into hasura:master Oct 26, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 26, 2018

Review app https://hge-ci-pull-672.herokuapp.com is deleted

@arzke
Copy link

arzke commented Nov 14, 2018

Does it allow to sort_by aggregated fields? Like { foo_aggregated_count: desc } ?

@rakeshkky
Copy link
Member Author

rakeshkky commented Nov 16, 2018

@brundozer Order by aggregated fields feature is being added. Please refer to #1042 PR for more details.

hasura-bot pushed a commit that referenced this pull request Jun 5, 2024
@danieljharvey @hasura-bot
Use newtypes for operator names (#672)
b314d89 
<!-- Thank you for submitting this PR! :) -->

## Description

We were using `String` for these, and making some assumptions about NDCs
and OpenDD operator names being the same. This uses newtypes and
documents where these assumptions are being made. Functional no-op.

V3_GIT_ORIGIN_REV_ID: 195e55db6fadf48c956684130e23f647eaa17fb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

Assignees

No one assigned

Labels

c/server Related to server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

allow ordering using columns from relationships

5 participants

@rakeshkky @hasura-bot @arzke @0x777 @shahidhk