这是indexloc提供的服务，不要输入任何密码
Skip to content

Modified update checker bar as footer below page elements (Fixes #271) #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Modified update checker bar as footer below page elements (Fixes #271) #667

wants to merge 4 commits into from

Conversation

@michizhou
Copy link
Contributor

@michizhou michizhou commented Oct 7, 2018

Description

Adds a new footer with proper CSS to resolve the issue of the update checker banner overlapping with console content, specifically the Run button on the Raw SQL page. Also decreased the height of the update checker banner to give a more streamlined appearance to the page.

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Closes #271

Solution and Design

  • Added a popupFooter div component that represents the update banner's position, which other page elements will respect (changes reflected in Main.js).
  • Added styling code for popupFooter div in Main.scss, setting the div height (17px) to a little more than the banner size in order to space out page components above the update checker.
  • The height of the update checker banner has been updated (16px) to be a little less than the original height as requested in the issue description.

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 7, 2018

Beep boop! 🤖

Hey @michizhou, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible. 🕐

Stay awesome! 😎

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 7, 2018

Review app available at: https://hge-ci-pull-667.herokuapp.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 7, 2018

Review app available at: https://hge-ci-pull-667.herokuapp.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 7, 2018

Review app available at: https://hge-ci-pull-667.herokuapp.com

@shahidhk shahidhk added the c/console Related to console label Oct 8, 2018
@karthikvt26
Copy link
Contributor

karthikvt26 commented Oct 8, 2018

@michizhou I am seeing the update banner as in the below screenshot. Its not entirely visible.

screenshot 540

Am I missing something here?

karthikvt26
karthikvt26 requested changes Oct 8, 2018
View reviewed changes
console/src/components/Main/Main.js
</div>
<div>
<div className={styles.popupFooter} />
<div className={styles.updateBannerWrapper}>
Copy link
Contributor

@karthikvt26 karthikvt26 Oct 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not visible completely

@shahidhk
Copy link
Member

shahidhk commented Oct 8, 2018

Hi @michizhou. Thanks for the PR 🙏 😄

There was already a a pull request open solving the same issue: #665, which looks like a better implementation. I am closing this one in favour of the other one.

Thanks again for your efforts. Feel free to pickup another issue.

@shahidhk shahidhk closed this Oct 8, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 8, 2018

Beep boop! 🤖

Hey @michizhou!

Sorry that your PR wasn’t merged. 😢

We appreciate your effort and want to reward you with some Hasura swag! 😎

Please do fill out 📝 this form so we can 🚢 them to you.

And do take a look at any of the other open 📂 issues to see if you’d like to take something up! We’re around on Discord & Twitter if you have any questions 😄

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 8, 2018

Review app https://hge-ci-pull-667.herokuapp.com is deleted

@michizhou michizhou deleted the dev-michizhou branch November 8, 2018 02:49
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 19, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 359d421
Status:⚡️  Build in progress...

View logs

@Allymahmoud Allymahmoud mentioned this pull request Dec 22, 2022
Open
hasura-bot pushed a commit that referenced this pull request Jun 6, 2024
@ecthiender @hasura-bot
Argument presets for DataConnectorLink Pt. 1 (#667)
9044471 
## Description

This PR implements argument presets and response headers for
`DataConnectorLink`, which can be used to forward request headers as
function/procedure arguments to NDC, and also forward response headers
from NDC back to the client. This PR implements only the OpenDD changes
and metadata resolving part.

V3_GIT_ORIGIN_REV_ID: 2b7f20af7c2f192c0103553bccb000114dcba916
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthikvt26 karthikvt26 karthikvt26 requested changes

Assignees

No one assigned

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

update checker bottom-bar hiding the run button under sql tab

5 participants

@michizhou @hasura-bot @CLAassistant @karthikvt26 @shahidhk