这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@akshitbhalla
Copy link
Contributor

Fixes issue #271.

Description

I implemented this StackOverflow answer for fixing the overlapping of the bottom banner with page content (Run button under sql tab).

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Fixes #271

Solution and Design

This is a link to the sandbox wherein I tested these changes.

  • Added a phantom div component that represents the banner's position which other dom elements will respect (change in Main.js).
  • Added styling code for phantom div in Main.scss.
    • I've set the phantom div height (17.5px) to a little higher than the banner size (14.5px), so that page components are spaced a little above the banner.

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @akshitbhalla, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible. 🕐

Stay awesome! 😎

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2018

CLA assistant check
All committers have signed the CLA.

@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-665.herokuapp.com

@shahidhk shahidhk added the c/console Related to console label Oct 8, 2018
@shahidhk shahidhk changed the title add phantom div for banner (Fix #271) add phantom div for update check banner (fix #271) Oct 8, 2018
@shahidhk shahidhk merged commit fc68477 into hasura:master Oct 8, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-665.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Whoa! 🎉 🎉 💃

GIF

Awesome work @akshitbhalla! 💪 🏆 All of us at Hasura ❤️ what you did.

We would love to send you some swag! 👕 Please allow us to do so by filling this form.

If you have any questions, ask us on our Discord & Twitter!

Thanks again 🤗

@akshitbhalla
Copy link
Contributor Author

Thanks!

I appreciate everyone at Hasura for all the cool things you do.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 28, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3ceb917
Status:🚫  Build failed.

View logs

hasura-bot pushed a commit that referenced this pull request Jun 5, 2024
This means we can use the cache far more often.

Pull requests will also use "dev" so as to avoid rebuilding
unnecessarily. Only builds on the `main` branch and tags will set a
version (using the short Git commit hash).

V3_GIT_ORIGIN_REV_ID: 37acaec3d369eef6df6487f9612f6d2da3e3ba5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update checker bottom-bar hiding the run button under sql tab

5 participants