add keybinding to submit sql query (close #542) #664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
Beep boop! 🤖 Hey @sdabhi23, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. 🕐 Stay awesome! 😎 |
Contributor
|
Review app available at: https://hge-ci-pull-664.herokuapp.com |
karthikvt26
approved these changes
Oct 8, 2018
Contributor
Contributor
|
Review app https://hge-ci-pull-664.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
## Description We can use Nix to build Docker images, which gives us a few advantages: 1. the images will be cached a little better 2. aarch64 builds become easy 3. Samir is happy because the Nixification continues ## Changelog - Add a changelog entry (in the "Changelog entry" section below) if the changes in this PR have any user-facing impact. See [changelog guide](https://github.com/hasura/graphql-engine-mono/wiki/Changelog-Guide). - If no changelog is required ignore/remove this section and add a `no-changelog-required` label to the PR. ### Product _(Select all products this will be available in)_ - [x] community-edition - [ ] cloud <!-- product : end : DO NOT REMOVE --> ### Type <!-- See changelog structure: https://github.com/hasura/graphql-engine-mono/wiki/Changelog-Guide#structure-of-our-changelog --> _(Select only one. In case of multiple, choose the most appropriate)_ - [ ] highlight - [x] enhancement - [ ] bugfix - [ ] behaviour-change - [ ] performance-enhancement - [ ] security-fix <!-- type : end : DO NOT REMOVE --> ### Changelog entry <!-- - Add a user understandable changelog entry - Include all details needed to understand the change. Try including links to docs or issues if relevant - For Highlights start with a H4 heading (#### <entry title>) - Get the changelog entry reviewed by your team --> The v3 engine and dev-auth-webhook Docker images are now published for both x86_64 (`amd64`) and aarch64 (`arm64`) architectures. <!-- changelog-entry : end : DO NOT REMOVE --> <!-- changelog : end : DO NOT REMOVE --> Co-Authored-By: Philip Carlsen <philip@hasura.io> Co-Authored-By: Gil Mizrahi <gil@hasura.io> V3_GIT_ORIGIN_REV_ID: ae6fec45dee62a21f03b5258b57d841a16542c72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add keyboard shortcut ctrl + enter to execute sql queries
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
Fix #542
Solution and Design
Run!button's onClick eventCtrl+Enterkey press and all the function which executes the sql queryType
Checklist: