这是indexloc提供的服务，不要输入任何密码
Skip to content

Reload metadata button appears for PR versions (fixes #618) #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 9, 2018
Merged

Reload metadata button appears for PR versions (fixes #618) #662

merged 5 commits into from
Oct 9, 2018

Conversation

@pmc-a
Copy link
Contributor

@pmc-a pmc-a commented Oct 6, 2018

Description

Adding semver validation check before attempting to compare versions. Fix removes error message from console (both from Main.js and Metadata.js).

Reload metadata now appears if version is a PR version.

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Fixes #618

Solution and Design

semver has a function that allows us to validate the version we're passing in. Adding this function call in before we perform the comparison between versions.

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@CLAassistant
Copy link

CLAassistant commented Oct 6, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 6, 2018

Beep boop! 🤖

Hey @pmc-a!

Thanks for your PR! ✨

I can't wait to merge it 🤞 🛠️, but I don't have the permissions to do so. ❌

One of my human 👩 friends will review the changes 📝 and get back to you as soon as possible. 🕐

Stay awesome! 😎

@shahidhk shahidhk requested a review from praveenweb October 8, 2018 06:14
@shahidhk shahidhk added the c/console Related to console label Oct 8, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 8, 2018

Review app available at: https://hge-ci-pull-662.herokuapp.com

shahidhk
shahidhk requested changes Oct 8, 2018
View reviewed changes
Copy link
Member

@shahidhk shahidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @pmc-a 🙏 😄

I checked out the review app at https://hge-ci-pull-662.herokuapp.com/console

The reload metadata section appears as expected 👏

But the Events tab has disappeared 😢. Can you check that out? The same behaviour applies for events tab also. If version > alpha15, show that tab, if the check fails, show the tab.

@pmc-a
Copy link
Contributor Author

pmc-a commented Oct 8, 2018 •
edited
Loading

Thanks for the feedback @shahidhk!

I've updated the PR, please have a look and let me know what you think! 😁

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 8, 2018

Review app available at: https://hge-ci-pull-662.herokuapp.com

@shahidhk
Copy link
Member

shahidhk commented Oct 9, 2018

LGTM. @praveenweb Can you check if this branch needs to be updated in light of #676 ?

Otherwise, let's merge.

@praveenweb
Copy link
Member

praveenweb commented Oct 9, 2018

@shahidhk - #676 is a larger update and can be updated after merging this.

@shahidhk shahidhk merged commit 936d4c7 into hasura:master Oct 9, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 9, 2018

Review app https://hge-ci-pull-662.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 9, 2018

Beep boop! 🤖

Whoa! 🎉 🎉 💃

GIF

Awesome work @pmc-a! 💪 🏆 All of us at Hasura ❤️ what you did.

We would love to send you some swag! 👕 Please allow us to do so by filling this form.

If you have any questions, ask us on our Discord & Twitter!

Thanks again 🤗

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 24, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 50bdd96
Status:🚫  Build failed.

View logs

hasura-bot pushed a commit that referenced this pull request Jun 5, 2024
@SamirTalwar @hasura-bot
Enable a few lint warnings around conditions, and fix the highlighted…
7281322 
… areas. (#662)

1. Use `map_or(…, …)` instead of `.map(…).unwrap_or(…)`.
2. Use `.is_some_and(…)` instead of `.map(…).unwrap_or_default(…)`.
3. Nest `|` patterns where possible.
4. Be more specific about match patterns.

I found I could also simplify `typecheck_qualified_type_reference`
considerably.

V3_GIT_ORIGIN_REV_ID: 6a3b1a4c525c0187c2fdb6df0c979ca0b7b3016c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

@praveenweb praveenweb praveenweb approved these changes

Assignees

No one assigned

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

reload metadata button should be shown if version check fails

5 participants

@pmc-a @CLAassistant @hasura-bot @shahidhk @praveenweb