这是indexloc提供的服务，不要输入任何密码
Skip to content

breaking: encode bigint and bigserial postgres types as strings (fix #633) #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 5, 2018
Merged

breaking: encode bigint and bigserial postgres types as strings (fix #633) #640

merged 2 commits into from
Oct 5, 2018

Conversation

@rakeshkky
Copy link
Member

@rakeshkky rakeshkky commented Oct 4, 2018 •
edited by shahidhk
Loading

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

fix #633

Solution and Design

select bigint and bigserial columns as texts.
Ex:- select "big_id"::text .. instead of select "big_id" ..

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@rakeshkky rakeshkky requested a review from 0x777 October 4, 2018 08:34
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 4, 2018

Review app available at: https://hge-ci-pull-640.herokuapp.com

@shahidhk shahidhk added the c/server Related to server label Oct 4, 2018
@shahidhk shahidhk changed the title encode bigint and bigserial postgres types as strings (fix #633) breaking: encode bigint and bigserial postgres types as strings (fix #633) Oct 4, 2018
@rakeshkky rakeshkky self-assigned this Oct 4, 2018
@rakeshkky rakeshkky added the s/ok-to-merge Status: This pull request can be merged to master label Oct 4, 2018
0x777
0x777 previously approved these changes Oct 4, 2018
View reviewed changes
@rakeshkky
Merge branch 'master' into issue-633
4d271f3 
Resolve Conflicts:
	server/tests-py/queries/graphql_query/basic/teardown.yaml
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 4, 2018

Review app available at: https://hge-ci-pull-640.herokuapp.com

@shahidhk shahidhk merged commit 9137631 into hasura:master Oct 5, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 5, 2018

Review app https://hge-ci-pull-640.herokuapp.com is deleted

@0x777 0x777 mentioned this pull request Jan 30, 2019
Closed
@Allymahmoud Allymahmoud mentioned this pull request Dec 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

@0x777 0x777 0x777 approved these changes

Assignees

@rakeshkky rakeshkky

Labels

c/server Related to server s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bigints are encoded as javascript numbers

4 participants

@rakeshkky @hasura-bot @shahidhk @0x777