这是indexloc提供的服务，不要输入任何密码
Skip to content

env variable to enable console (close #632) #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2018
Merged

env variable to enable console (close #632) #642

merged 1 commit into from
Oct 10, 2018

Conversation

@rakeshkky
Copy link
Member

@rakeshkky rakeshkky commented Oct 4, 2018

Description

HASURA_GRAPHQL_ENABLE_CONSOLE env variable for --enable-console flag.

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

close #632

Solution and Design

If --enable-console flag is not given, server will look up for HASURA_GRAPHQL_ENABLE_CONSOLE env variable. Allowed values for True are true, t, yes and y. For False false, f, no and n.

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@rakeshkky rakeshkky requested a review from 0x777 October 4, 2018 10:11
@rakeshkky rakeshkky self-assigned this Oct 4, 2018
@rakeshkky rakeshkky added s/ok-to-merge Status: This pull request can be merged to master c/server Related to server labels Oct 4, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 4, 2018

Review app available at: https://hge-ci-pull-642.herokuapp.com

@UtkarshGupta-CS UtkarshGupta-CS mentioned this pull request Oct 4, 2018
Closed
@shahidhk
Copy link
Member

shahidhk commented Oct 10, 2018 •
edited
Loading

Need changes to heroku repo.

@shahidhk
Copy link
Member

shahidhk commented Oct 10, 2018

PR to be merged on next release: hasura/graphql-engine-heroku#19

@shahidhk shahidhk merged commit be28f8c into hasura:master Oct 10, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 10, 2018

Review app https://hge-ci-pull-642.herokuapp.com is deleted

zaffnet pushed a commit to zaffnet/graphql-engine that referenced this pull request Oct 11, 2018
@rakeshkky @zaffnet
add env var to enable console (close hasura#632) (hasura#642)
f70d699 
Small Improvement to README
hasura-bot pushed a commit that referenced this pull request Jun 1, 2024
@plcplc @hasura-bot
SDL schema generation improvements (#642)
812f44f 
Add the ability to render field input-arguments and default values in
sdl.

Also add a small CLI tool to help inspect the GraphQL schemas that
result from a piece of engine metadata.

V3_GIT_ORIGIN_REV_ID: ddb7315f12d24eafbf57782f37f840ca44d94789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

Assignees

@rakeshkky rakeshkky

Labels

c/server Related to server s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use env variable to define whether to show console or not

4 participants

@rakeshkky @hasura-bot @shahidhk @0x777