这是indexloc提供的服务，不要输入任何密码
Skip to content

configuration list is alphabetical, add note in sql tab for down migrations (close #616) (close #617) #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2018
Merged

configuration list is alphabetical, add note in sql tab for down migrations (close #616) (close #617) #638

merged 1 commit into from
Oct 4, 2018

Conversation

@karthikvt26
Copy link
Contributor

@karthikvt26 karthikvt26 commented Oct 4, 2018

Fix #616, #617

Description

Adds order_by clause to queries to solve #617 and adds a note to fix #616

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@karthikvt26 karthikvt26 requested a review from praveenweb October 4, 2018 07:14
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 4, 2018

Review app available at: https://hge-ci-pull-638.herokuapp.com

@praveenweb praveenweb added the c/console Related to console label Oct 4, 2018
praveenweb
praveenweb approved these changes Oct 4, 2018
View reviewed changes
Copy link
Member

@praveenweb praveenweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praveenweb praveenweb added the s/ok-to-merge Status: This pull request can be merged to master label Oct 4, 2018
@shahidhk shahidhk changed the title Orders configuration list items in alphabetical order and adds a note in raw sql configuration list is alphabetical, add note in sql tab for down migrations (close #616) (close #617) Oct 4, 2018
@shahidhk shahidhk merged commit b07d04a into hasura:master Oct 4, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 4, 2018

Review app https://hge-ci-pull-638.herokuapp.com is deleted

@Allymahmoud Allymahmoud mentioned this pull request Dec 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

Assignees

No one assigned

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

notify user that down migrations are not generated when raw sql is executed

4 participants

@karthikvt26 @hasura-bot @praveenweb @shahidhk