apply update permissions for upsert mutations #628

rakeshkky · 2018-10-03T14:02:50Z

Description

What component does this PR affect?

Requires changes from other components? If yes, please mark the components:

Solution and Design

if on_conflict clause results in DO UPDATE .. then use update
permission filter expression in WHERE clause
validate input columns against columns specified in update permission
remove action argument in on_conflict input object. update_columns argument is mandatory.

input table_on_conflict {
  constraint: table_constraint!
  update_columns: [table_update_column!]!
}

Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Docs update
Community content

Checklist:

I have read the contributing guide and my code conforms to the guidelines.
This change requires a change in the documentation.
I have updated the documentation accordingly.
I have added and modified required tests.

-> if `on_conflict` clause results in `DO UPDATE ..` then use update permission filter in `WHERE` clause -> validate input columns against columna specified in update permission

Resolve Conflicts: server/src-lib/Hasura/RQL/DML/Insert.hs server/tests-py/queries/graphql_mutation/insert/permissions/author_user_role_insert_check_perm_success.yaml server/tests-py/queries/graphql_mutation/insert/permissions/company_user_role_on_conflict.yaml

hasura-bot · 2018-10-03T14:24:08Z

Review app available at: https://hge-ci-pull-628.herokuapp.com

Resolve Conflicts: server/src-lib/Hasura/GraphQL/Resolve.hs server/src-lib/Hasura/GraphQL/Resolve/Mutation.hs server/src-lib/Hasura/GraphQL/Schema.hs server/src-lib/Hasura/RQL/DML/Insert.hs server/src-lib/Hasura/SQL/DML.hs

hasura-bot · 2018-11-05T12:30:46Z

Review app available at: https://hge-ci-pull-628.herokuapp.com

shahidhk · 2018-11-06T12:38:49Z

@0x777 @rakeshkky What is the status on this PR?

Resolve Conflicts: server/src-lib/Hasura/GraphQL/Resolve/Insert.hs server/src-lib/Hasura/GraphQL/Schema.hs server/src-lib/Hasura/RQL/DDL/Permission.hs

hasura-bot · 2018-11-20T06:59:35Z

Review app available at: https://hge-ci-pull-628.herokuapp.com

0x777 · 2018-11-20T09:26:13Z

@karthikvt26 We are removing 'allow upsert queries' from insert permissions. They are automatically determined from update permissions.

Automatically determine upsert permission from update permission

dsandip · 2018-11-21T05:44:40Z

@rakeshkky @0x777 Do we need to make the console changes before this is merged/released? Also, how is the upgrade going to be handled for people who are currently using this config?

karthikvt26 · 2018-11-21T05:47:53Z

@dsandip rishi is taking a look at it. Console tests are failing due to this change.

rakeshkky · 2018-11-21T05:52:07Z

@rakeshkky @0x777 Do we need to make the console changes before this is merged/released? Also, how is the upgrade going to be handled for people who are currently using this config?

@dsandip Console changes are required. Existing users have to define update permissions on tables to enable upsert.

Explicitly compute `isUpsertable` during schema generation

hasura-bot · 2018-11-21T14:04:23Z

Review app available at: https://hge-ci-pull-628.herokuapp.com

karthikvt26

Tested console and it looks fine.

hasura-bot · 2018-11-23T15:56:08Z

Review app for commit 5ba6e6b deployed to Heroku: https://hge-ci-pull-628.herokuapp.com
Docker image for server: hasura/graphql-engine:pull628-5ba6e6b

'update_columns' argument is mandatory

…ne into internal-issue-36

hasura-bot · 2018-11-28T14:59:15Z

Review app for commit eedf22a deployed to Heroku: https://hge-ci-pull-628.herokuapp.com
Docker image for server: hasura/graphql-engine:pull628-eedf22a

Resolve Conflicts: docs/graphql/manual/mutations/upsert.rst server/tests-py/queries/graphql_mutation/insert/nested/articles_with_author_author_id_fail.yaml server/tests-py/queries/graphql_mutation/insert/nested/author_with_articles_author_id_fail.yaml

hasura-bot · 2018-12-05T09:28:21Z

Review app for commit c8c9868 deployed to Heroku: https://hge-ci-pull-628.herokuapp.com
Docker image for server: hasura/graphql-engine:pull628-c8c9868

Resolve Conflicts: server/src-lib/Hasura/GraphQL/Resolve/Context.hs server/src-lib/Hasura/Prelude.hs

0x777 · 2018-12-14T07:25:41Z

@rikinsk You'll need to review the docs.

hasura-bot · 2018-12-14T07:29:29Z

Review app for commit 4f34a97 deployed to Heroku: https://hge-ci-pull-628.herokuapp.com
Docker image for server: hasura/graphql-engine:pull628-4f34a97

rikinsk-zz

Docs approved

hasura-bot · 2018-12-14T09:39:01Z

Review app for commit 2e72d0b deployed to Heroku: https://hge-ci-pull-628.herokuapp.com
Docker image for server: hasura/graphql-engine:pull628-2e72d0b

hasura-bot · 2018-12-14T15:02:11Z

Review app for commit d5f547e deployed to Heroku: https://hge-ci-pull-628.herokuapp.com
Docker image for server: hasura/graphql-engine:pull628-d5f547e

hasura-bot · 2018-12-15T14:53:50Z

Review app for commit a6c981a deployed to Heroku: https://hge-ci-pull-628.herokuapp.com
Docker image for server: hasura/graphql-engine:pull628-a6c981a

hasura-bot · 2018-12-15T16:10:31Z

Review app https://hge-ci-pull-628.herokuapp.com is deleted

## Description In hasura/v3-engine#599 we added new `BooleanExpressionType` to OpenDD. It included a number of helpful newtypes such as `DataConnectorScalarType` that replace uses of raw string and make intent inside engine code easier to follow. This change uses that newtype everywhere in `metadata-resolve`.  ## Changelog - Add a changelog entry (in the "Changelog entry" section below) if the changes in this PR have any user-facing impact. See [changelog guide](https://github.com/hasura/graphql-engine-mono/wiki/Changelog-Guide). - If no changelog is required ignore/remove this section and add a `no-changelog-required` label to the PR. ### Product _(Select all products this will be available in)_ - [X] community-edition - [X] cloud  ### Type  _(Select only one. In case of multiple, choose the most appropriate)_ - [ ] highlight - [X] enhancement - [ ] bugfix - [ ] behaviour-change - [ ] performance-enhancement - [ ] security-fix  ### Changelog entry  Use `DataConnectorScalarType` string newtype internallly and in OpenDD types.   V3_GIT_ORIGIN_REV_ID: b44709f39b30f25908106110f62c72e3d13b4eb6

rakeshkky added 2 commits October 3, 2018 19:02

consider update permissions in upsert mutation

3eb94fa

-> if `on_conflict` clause results in `DO UPDATE ..` then use update permission filter in `WHERE` clause -> validate input columns against columna specified in update permission

rakeshkky added s/ok-to-merge Status: This pull request can be merged to master c/server Related to server labels Oct 3, 2018

rakeshkky self-assigned this Oct 3, 2018

rakeshkky requested a review from 0x777 October 3, 2018 14:02

rakeshkky added 2 commits November 5, 2018 17:01

Merge branch 'master' into internal-issue-36

dc20a52

Resolve Conflicts: server/src-lib/Hasura/GraphQL/Resolve.hs server/src-lib/Hasura/GraphQL/Resolve/Mutation.hs server/src-lib/Hasura/GraphQL/Schema.hs server/src-lib/Hasura/RQL/DML/Insert.hs server/src-lib/Hasura/SQL/DML.hs

clean 'Mutation.hs'

2b76534

Merge branch 'master' into internal-issue-36

6c66abb

Resolve Conflicts: server/src-lib/Hasura/GraphQL/Resolve/Insert.hs server/src-lib/Hasura/GraphQL/Schema.hs server/src-lib/Hasura/RQL/DDL/Permission.hs

0x777 added the c/console Related to console label Nov 20, 2018

0x777 assigned karthikvt26 Nov 20, 2018

remove 'allow_upsert' field in insert permission definition

d4294bb

Automatically determine upsert permission from update permission

remote 'ipiAllowUpsert' field from 'InsPermInfo'

dc4f9ad

Explicitly compute `isUpsertable` during schema generation

0x777 added this to the v1.0.0-alpha31 milestone Nov 21, 2018

rakeshkky and others added 2 commits November 21, 2018 17:31

update docs for upsert

e197a52

hide upsert option in console alpha30 onwards

5af31bc

wawhal requested a review from karthikvt26 November 21, 2018 13:39

rakeshkky and others added 2 commits November 22, 2018 12:52

Merge branch 'master' into internal-issue-36

57f441d

remove margin left from insert presets

50a2b7f

karthikvt26 previously approved these changes Nov 22, 2018

View reviewed changes

wawhal dismissed karthikvt26’s stale review via 50a2b7f November 22, 2018 07:31

Merge branch 'master' into internal-issue-36

5ba6e6b

0x777 modified the milestones: v1.0.0-alpha31, v1.0.0-alpha32 Nov 27, 2018

rakeshkky added 3 commits November 28, 2018 18:19

Merge branch 'master' into internal-issue-36

b01a0b2

remove 'action' argument in 'on_conflict' input object

727f203

'update_columns' argument is mandatory

Merge branch 'internal-issue-36' of github.com:rakeshkky/graphql-engi…

eedf22a

…ne into internal-issue-36

Merge branch 'master' into internal-issue-36

4f34a97

Resolve Conflicts: server/src-lib/Hasura/GraphQL/Resolve/Context.hs server/src-lib/Hasura/Prelude.hs

0x777 requested a review from rikinsk-zz December 14, 2018 07:25

upsert docs update

2e72d0b

rikinsk-zz previously approved these changes Dec 14, 2018

View reviewed changes

0x777 previously approved these changes Dec 14, 2018

View reviewed changes

Update semver.js

b911da0

0x777 dismissed stale reviews from rikinsk-zz and themself via b911da0 December 14, 2018 14:27

Merge branch 'master' into internal-issue-36

d5f547e

Merge branch 'master' into internal-issue-36

a6c981a

0x777 approved these changes Dec 15, 2018

View reviewed changes

0x777 merged commit 3026c49 into hasura:master Dec 15, 2018

Allymahmoud mentioned this pull request May 23, 2023

[Snyk] Security upgrade posthog-js from 1.31.0 to 1.57.2 Allymahmoud/graphql-engine#210

Open

apply update permissions for upsert mutations #628

apply update permissions for upsert mutations #628

Uh oh!

Conversation

rakeshkky commented Oct 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Solution and Design

Type

Checklist:

Uh oh!

hasura-bot commented Oct 3, 2018

Uh oh!

hasura-bot commented Nov 5, 2018

Uh oh!

shahidhk commented Nov 6, 2018

Uh oh!

hasura-bot commented Nov 20, 2018

Uh oh!

0x777 commented Nov 20, 2018

Uh oh!

dsandip commented Nov 21, 2018

Uh oh!

karthikvt26 commented Nov 21, 2018

Uh oh!

rakeshkky commented Nov 21, 2018

Uh oh!

hasura-bot commented Nov 21, 2018

Uh oh!

karthikvt26 left a comment

Choose a reason for hiding this comment

Uh oh!

hasura-bot commented Nov 23, 2018

Uh oh!

hasura-bot commented Nov 28, 2018

Uh oh!

hasura-bot commented Dec 5, 2018

Uh oh!

0x777 commented Dec 14, 2018

Uh oh!

hasura-bot commented Dec 14, 2018

Uh oh!

rikinsk-zz left a comment

Choose a reason for hiding this comment

Uh oh!

hasura-bot commented Dec 14, 2018

Uh oh!

hasura-bot commented Dec 14, 2018

Uh oh!

hasura-bot commented Dec 15, 2018

Uh oh!

hasura-bot commented Dec 15, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

rakeshkky commented Oct 3, 2018 •

edited

Loading