ci: add hlint escape hatch #6164
Conversation
.github/workflows/hlint.yml
Outdated
| jobs: | ||
| hlint: | ||
| runs-on: ubuntu-20.04 | ||
| if: !contains(github.event.pull_request.labels.*.name, 'ignore-lint-checks') |
There was a problem hiding this comment.
calling it ignore-hlint-checks will disambiguate from other lints?
There was a problem hiding this comment.
SG! Sorry, this is still a draft, I'm testing that this works as expected, the documentation for actions is a bit lackluster. ^^
There was a problem hiding this comment.
I might settle for ignore-server-lint-checks, since I'm working on other lint steps that are not hlint I'd like to be able to disable if necessary.
abooij
left a comment
There was a problem hiding this comment.
I think I agree with @tirumaraiselvan's proposal for somehow putting hlint in the name of the label. A PR might touch both the console and the server, for instance, and we wouldn't want to get mixed up in which code linter needs to be switched off. I think it'd be preferable to have many different labels for many different linters than to have one big on/off switch, that may end up only switching off part of the linters.
339f584 to
f58f7bb
Compare
Description
This PR changes our check configuration:
ignore-server-lint-checksis presentThis is hard to test, given that
labelevents are only fired using the configuration as it is on main, according to the documentation. At the very least this runs, which means that even if it does not work as expected it won't break our workflows.If someone has any experience with actions and can check this, that'd be great!