这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@kraynel
Copy link
Contributor

@kraynel kraynel commented Oct 1, 2018

Description

Enables redux-dev-tools in development mode.

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#606

Solution and Design

image

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@kraynel kraynel changed the title Enable redux-dev-tools if present in dev mode (fixes #606) Enable redux-dev-tools if present in dev mode (closes #606) Oct 1, 2018
@shahidhk shahidhk added the c/console Related to console label Oct 2, 2018
@kraynel kraynel force-pushed the enable-redux-dev-tools branch from 2d58b50 to 62b5106 Compare October 2, 2018 07:59
@kraynel kraynel force-pushed the enable-redux-dev-tools branch from 62b5106 to 12cbb71 Compare October 2, 2018 08:00
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-607.herokuapp.com

@shahidhk
Copy link
Member

shahidhk commented Oct 4, 2018

@praveenweb @karthikvt26 Please review!

@karthikvt26
Copy link
Contributor

karthikvt26 commented Oct 4, 2018

@kraynel Thank you for the wonderful PR. It looks good 🏆. Can you also update the console README with this as an optional thing for development?

@karthikvt26
Copy link
Contributor

@kraynel any update on this?

@kraynel
Copy link
Contributor Author

kraynel commented Oct 5, 2018

@kraynel any update on this?

Of course, I'll try and commit that today.

@kraynel kraynel force-pushed the enable-redux-dev-tools branch from 149ec88 to 19948d7 Compare October 5, 2018 12:03
Copy link
Contributor

@karthikvt26 karthikvt26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahidhk shahidhk changed the title Enable redux-dev-tools if present in dev mode (closes #606) enable redux-dev-tools if present in dev mode (closes #606) Oct 5, 2018
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-607.herokuapp.com

@shahidhk shahidhk merged commit 5abd18a into hasura:master Oct 5, 2018
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Whoa! 🎉 🎉 💃

GIF

Awesome work @kraynel! 💪 🏆 All of us at Hasura ❤️ what you did.

We would love to send you some swag! 👕 Please allow us to do so by filling this form.

If you have any questions, ask us on our Discord & Twitter!

Thanks again 🤗

@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-607.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request May 23, 2024
## Description
This PR fixes a bug where the engine does not actually execute root
fields in parallel when it is supposed to be doing so.

Consider the following GraphQL query that is invoking a typescript
function that sleeps for 5 seconds three times:

```graphql
query MyQuery {
  test1: app_hello(name: "test1")
  test2: app_hello(name: "test2")
  test3: app_hello(name: "test3")
}
```

This should execute in 5 seconds, as these should be run in parallel.
Instead, it actually takes 15 seconds as they are run sequentially.

Here's a trace from before the change:

![image](https://github.com/hasura/v3-engine/assets/1214352/d52d99e7-b4da-4bbb-bbf9-5155ef568d76)

And here's a trace from after the change:

![image](https://github.com/hasura/v3-engine/assets/1214352/26a3ac1f-9e9c-4067-aa1b-62aaa4b293c2)

## Changelog

### Product

_(Select all products this will be available in)_

- [x] community-edition
- [x] cloud
<!-- product : end : DO NOT REMOVE -->

### Type

<!-- See changelog structure:
https://github.com/hasura/graphql-engine-mono/wiki/Changelog-Guide#structure-of-our-changelog
-->

_(Select only one. In case of multiple, choose the most appropriate)_

- [ ] highlight
- [ ] enhancement
- [x] bugfix
- [ ] behaviour-change
- [ ] performance-enhancement
- [ ] security-fix
<!-- type : end : DO NOT REMOVE -->

### Changelog entry

<!--
  - Add a user understandable changelog entry
- Include all details needed to understand the change. Try including
links to docs or issues if relevant
  - For Highlights start with a H4 heading (#### <entry title>)
  - Get the changelog entry reviewed by your team
-->

Fixed a bug in the engine that prevented the parallel execution of query
root fields

<!-- changelog-entry : end : DO NOT REMOVE -->

<!-- changelog : end : DO NOT REMOVE -->

V3_GIT_ORIGIN_REV_ID: 2d4dd195037d49577608892fc6fa0237d8fd26c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants