-
Notifications
You must be signed in to change notification settings - Fork 2.8k
enable redux-dev-tools if present in dev mode (closes #606) #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2d58b50 to
62b5106
Compare
62b5106 to
12cbb71
Compare
|
Review app available at: https://hge-ci-pull-607.herokuapp.com |
|
@praveenweb @karthikvt26 Please review! |
|
@kraynel Thank you for the wonderful PR. It looks good 🏆. Can you also update the console README with this as an optional thing for development? |
|
@kraynel any update on this? |
Of course, I'll try and commit that today. |
149ec88 to
19948d7
Compare
karthikvt26
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Review app available at: https://hge-ci-pull-607.herokuapp.com |
|
Review app https://hge-ci-pull-607.herokuapp.com is deleted |
## Description
This PR fixes a bug where the engine does not actually execute root
fields in parallel when it is supposed to be doing so.
Consider the following GraphQL query that is invoking a typescript
function that sleeps for 5 seconds three times:
```graphql
query MyQuery {
test1: app_hello(name: "test1")
test2: app_hello(name: "test2")
test3: app_hello(name: "test3")
}
```
This should execute in 5 seconds, as these should be run in parallel.
Instead, it actually takes 15 seconds as they are run sequentially.
Here's a trace from before the change:

And here's a trace from after the change:

## Changelog
### Product
_(Select all products this will be available in)_
- [x] community-edition
- [x] cloud
<!-- product : end : DO NOT REMOVE -->
### Type
<!-- See changelog structure:
https://github.com/hasura/graphql-engine-mono/wiki/Changelog-Guide#structure-of-our-changelog
-->
_(Select only one. In case of multiple, choose the most appropriate)_
- [ ] highlight
- [ ] enhancement
- [x] bugfix
- [ ] behaviour-change
- [ ] performance-enhancement
- [ ] security-fix
<!-- type : end : DO NOT REMOVE -->
### Changelog entry
<!--
- Add a user understandable changelog entry
- Include all details needed to understand the change. Try including
links to docs or issues if relevant
- For Highlights start with a H4 heading (#### <entry title>)
- Get the changelog entry reviewed by your team
-->
Fixed a bug in the engine that prevented the parallel execution of query
root fields
<!-- changelog-entry : end : DO NOT REMOVE -->
<!-- changelog : end : DO NOT REMOVE -->
V3_GIT_ORIGIN_REV_ID: 2d4dd195037d49577608892fc6fa0237d8fd26c4
Description
Enables redux-dev-tools in development mode.
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
#606
Solution and Design
Type
Checklist: