console: notifications bug fixes #6067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikvt26
reviewed
Oct 23, 2020
karthikvt26
requested changes
Oct 29, 2020
Contributor
karthikvt26
left a comment
There was a problem hiding this comment.
Before we save the notification state to the database, we should refetch and save. The problem here is lets say
- Admin has opened the console and the
console_notificationwould haveadminnotification usage info - Collaborator has opened the console and the
console_notificationwould haveadminrelated usage info andcollaboratornotification usage info.
Now if the admin doesn't refresh the page and does any operation such as read and this operation would remove the collaborator's activity and if collaborator refreshes the page they would see the badge and all the notification being unread
|
Deploy preview for hasura-docs ready! Built with commit 854d3b1 |
…notifications-fixes
…notifications-fixes
…notifications-fixes
karthikvt26
approved these changes
Nov 6, 2020
Contributor
karthikvt26
left a comment
There was a problem hiding this comment.
Verified the functionality
scriptonist
pushed a commit
to scriptonist/graphql-engine
that referenced
this pull request
Nov 8, 2020
beerose
pushed a commit
to beerose/graphql-engine
that referenced
this pull request
Nov 10, 2020
beerose
pushed a commit
to beerose/graphql-engine
that referenced
this pull request
Nov 10, 2020
beerose
pushed a commit
to beerose/graphql-engine
that referenced
this pull request
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some issues with #5070 for cloud and pro usage. There are also some additional types added related to the ReduxState which are kinda related to these fixes.
Affected components
Related issues
https://github.com/hasura/graphql-engine-pro/pull/600