fix parsing webhook response, closes #890 #894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Review app available at: https://hge-ci-pull-894.herokuapp.com |
rakeshkky
approved these changes
Oct 28, 2018
Contributor
|
Review app https://hge-ci-pull-894.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
<!-- The PR description should answer 2 (maybe 3) important questions: --> ### What We've had issues with `metadata-resolve` rejecting Elasticsearch schema output, so adding said output to this test. Appears to work fine, so merging it for further discussion and to improve the test case. <!-- What is this PR trying to accomplish (and why, if it's not obvious)? --> <!-- Consider: do we need to add a changelog entry? --> ### How Add elastic search schema to test. <!-- How is it trying to accomplish it (what are the implementation steps)? --> V3_GIT_ORIGIN_REV_ID: ea7c39ca7ab07fc18abd08eb822d2d56fc152ae6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is introduced with the refactor related to user variables throughout the codebase.
Description
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
#890
Solution and Design
Type
Checklist: