这是indexloc提供的服务，不要输入任何密码
Skip to content

pep8 fixes for python files #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 30, 2018
Merged

pep8 fixes for python files #875

merged 4 commits into from
Oct 30, 2018

Conversation

@vkmrishad
Copy link
Contributor

@vkmrishad vkmrishad commented Oct 26, 2018 •
edited
Loading

Description

  • Python PEP8 Style fixes

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 26, 2018

Beep boop! 🤖

Hey @vkmrishad, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible. 🕐

Stay awesome! 😎

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 26, 2018

Review app available at: https://hge-ci-pull-875.herokuapp.com

@shahidhk
Copy link
Member

shahidhk commented Oct 29, 2018

Thanks @vkmrishad. Can you resolve the conflicts with master branch?

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 29, 2018

Review app available at: https://hge-ci-pull-875.herokuapp.com

@vkmrishad
Copy link
Contributor Author

vkmrishad commented Oct 29, 2018

@shahidhk
Conflict fixed.

@rishad-sayone

@vkmrishad
Copy link
Contributor Author

vkmrishad commented Oct 29, 2018

@shahidhk
Can you please merge this PR

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 30, 2018

Review app available at: https://hge-ci-pull-875.herokuapp.com

@shahidhk shahidhk changed the title Python PEP8 Fixes pep8 fixes for python files Oct 30, 2018
@shahidhk shahidhk merged commit 58ccddc into hasura:master Oct 30, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 30, 2018

Review app https://hge-ci-pull-875.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 30, 2018

Beep boop! 🤖

Whoa! 🎉 🎉 💃

GIF

Awesome work @vkmrishad! 💪 🏆 All of us at Hasura ❤️ what you did.

We would love to send you some swag! Please fill this form.

If you have any questions, ask us on our Discord & Twitter!

Thanks again 🤗

@vkmrishad
Copy link
Contributor Author

vkmrishad commented Oct 30, 2018

@shahidhk
Thank you

hasura-bot pushed a commit that referenced this pull request Jul 24, 2024
@rakeshkky @hasura-bot
[changelog] release v2024.07.24 (#875)
bf1fd4d 
Update changelog for release v2024.07.24

V3_GIT_ORIGIN_REV_ID: 7a87941774635dd1fb0e98ac406a88908fa55ba4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vkmrishad @CLAassistant @hasura-bot @shahidhk @rishad-sayone