这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@karthikvt26
Copy link
Contributor

Fix #654

Description

Removed jsx portions for insert/update and changes section header and the tooltip.

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@karthikvt26 karthikvt26 added the c/console Related to console label Oct 26, 2018
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-868.herokuapp.com

praveenweb
praveenweb previously approved these changes Oct 26, 2018
@praveenweb praveenweb added the s/ok-to-merge Status: This pull request can be merged to master label Oct 26, 2018
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-868.herokuapp.com

@praveenweb praveenweb changed the title Removes insert/update from advanced settings, changes advanced settin… update advanced settings in create trigger page Oct 27, 2018
@shahidhk shahidhk changed the title update advanced settings in create trigger page update advanced settings in create trigger page (close #654) Oct 27, 2018
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-868.herokuapp.com

@shahidhk shahidhk merged commit 92182e9 into hasura:master Oct 27, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-868.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Jul 23, 2024
### What

This PR enables the use of Opentelemetry Baggage. Every bit of baggage
is then replicated on every span.

The current implementation does not actually set any baggage itself - it
only relays and outputs what it's getting.

Crafting a request with a `baggage` header set:

![image](https://github.com/user-attachments/assets/f2974398-370a-4e8c-8761-692cfc5682f6)

Has it propagated (here, to `dev-auth-webhook`) and stamped onto every
span:

![image](https://github.com/user-attachments/assets/6661c41f-56be-4edd-9027-e88eb816f1e7)

### How

This PR actually makes the engine and auth-hook use the globally
specified propagators (before they would only use an obsucre, concrete,
re-exported one from opentelemetry_contrib), and adds the
`BaggagePropagator` to the list.

It also adds a `SpanProcessor` which outputs the baggage as span
attributes. Currently it outputs all Baggage entries, but can be made
more specific in the future if we want to treat Baggage differently.

V3_GIT_ORIGIN_REV_ID: 3b5b8604b624c0b90c192e68b3b57fab7ca9b63e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI for triggering events on changes to only select columns (for #547)

4 participants