allow unauthorized role in accesskey and JWT modes (close #595) #856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Review app available at: https://hge-ci-pull-856.herokuapp.com |
0x777
reviewed
Oct 25, 2018
Member
|
do not allow unauthorized role for webhook |
Contributor
|
Review app available at: https://hge-ci-pull-856.herokuapp.com |
1 similar comment
Contributor
|
Review app available at: https://hge-ci-pull-856.herokuapp.com |
0x777
reviewed
Oct 25, 2018
server/src-lib/Hasura/Server/Auth.hs
Outdated
| where | ||
| unAuthRoleNotReqForWebHook = | ||
| when (isJust mUnAuthRole) $ | ||
| throwError $ "Fatal Error: --unauthorized-role (HASURA_GRAPHQL_UNAUTHORIZED_ROLE) is not required" |
Contributor
|
Review app available at: https://hge-ci-pull-856.herokuapp.com |
1 similar comment
Contributor
|
Review app available at: https://hge-ci-pull-856.herokuapp.com |
0x777
approved these changes
Oct 25, 2018
Contributor
|
Review app https://hge-ci-pull-856.herokuapp.com is deleted |
This was referenced Dec 22, 2022
This was referenced Dec 19, 2023
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--unauthorized-roleflag orHASURA_GRAPHQL_UNAUTHORIZED_ROLEenv variable can be specified (optional) in following modes:In access-key only mode, when the
x-hasura-access-keyis absent, the query will be executed using the role specified withunauthorized-roleoption. JWT mode will have the same behavior when theAuthorizationheader is absent in the request.unauthorized-roleoption is not required for Webhook mode.What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
closes #595
Solution and Design
Type
Checklist: