这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@rakeshkky
Copy link
Member

Description

Total refactor of nested insert mutation internal code.

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

fix #844

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have modified required tests.

@rakeshkky rakeshkky requested a review from 0x777 October 24, 2018 15:25
@rakeshkky rakeshkky self-assigned this Oct 24, 2018
@rakeshkky rakeshkky added c/server Related to server s/ok-to-merge Status: This pull request can be merged to master labels Oct 24, 2018
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-852.herokuapp.com

Resolve Conflicts:
	server/src-lib/Hasura/GraphQL/Resolve/Context.hs
	server/src-lib/Hasura/GraphQL/Resolve/Insert.hs
	server/src-lib/Hasura/GraphQL/Resolve/Mutation.hs
	server/src-lib/Hasura/RQL/DML/Returning.hs
	server/src-lib/Hasura/RQL/DML/Select.hs
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-852.herokuapp.com

Resolve Conflicts:
	server/src-lib/Hasura/GraphQL/Resolve/Insert.hs
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-852.herokuapp.com

rakeshkky and others added 2 commits November 2, 2018 14:46
Resolve Conflicts:
	server/src-lib/Hasura/GraphQL/Resolve/Insert.hs
	server/src-lib/Hasura/GraphQL/Resolve/Mutation.hs
	server/src-lib/Hasura/RQL/DML/Returning.hs
	server/src-lib/Hasura/RQL/DML/Select.hs
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-852.herokuapp.com

0x777
0x777 previously approved these changes Nov 2, 2018
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-852.herokuapp.com

@0x777 0x777 merged commit 0e9d699 into hasura:master Nov 2, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-852.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/server Related to server s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

issue with insert nested object

3 participants