这是indexloc提供的服务，不要输入任何密码
Skip to content

fix quote schema identifier (close #837) #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2018
Merged

fix quote schema identifier (close #837) #838

merged 1 commit into from
Oct 26, 2018

Conversation

@arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented Oct 23, 2018

Description

Add quotes to schema name.

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#837

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@arvi3411301 arvi3411301 added s/do-not-merge Do not merge this pull request to master c/console Related to console labels Oct 23, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 23, 2018

Review app available at: https://hge-ci-pull-838.herokuapp.com

praveenweb
praveenweb approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@praveenweb praveenweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praveenweb praveenweb added s/ok-to-merge Status: This pull request can be merged to master and removed s/do-not-merge Do not merge this pull request to master labels Oct 25, 2018
@shahidhk shahidhk merged commit e437604 into hasura:master Oct 26, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 26, 2018

Review app https://hge-ci-pull-838.herokuapp.com is deleted

@arvi3411301 arvi3411301 deleted the issue-837 branch January 3, 2019 11:02
@sumodgeorge sumodgeorge mentioned this pull request Nov 28, 2023
Open
@Allymahmoud Allymahmoud mentioned this pull request Nov 28, 2023
Open
@sumodgeorge sumodgeorge mentioned this pull request Dec 1, 2023
Open
@ptakpatryk ptakpatryk mentioned this pull request Dec 19, 2023
Open
This was referenced Dec 19, 2023
Open
Open
@ptakpatryk ptakpatryk mentioned this pull request Dec 19, 2023
Open
@sumodgeorge sumodgeorge mentioned this pull request Dec 20, 2023
Open
This was referenced Mar 22, 2024
Open
Open
@sumodgeorge sumodgeorge mentioned this pull request Mar 23, 2024
Open
hasura-bot pushed a commit that referenced this pull request Jul 16, 2024
@robertjdominguez @hasura-bot
Bug Bash: Fix typo (#838)
9f6ac66 
### What

This closes #10433 and closes
hasura/v3-engine-multitenant#917

[DOCS-2225](https://hasurahq.atlassian.net/browse/DOCS-2225)

[DOCS-2225]:
https://hasurahq.atlassian.net/browse/DOCS-2225?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

V3_GIT_ORIGIN_REV_ID: 8c9d161af0737ecfee973d0083198617e21329de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

Assignees

No one assigned

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arvi3411301 @hasura-bot @praveenweb @shahidhk