这是indexloc提供的服务，不要输入任何密码
Skip to content

Include sql formatter and highligher as part of the bundle itself #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 19, 2018
Merged

Include sql formatter and highligher as part of the bundle itself #819

merged 5 commits into from
Oct 19, 2018

Conversation

@karthikvt26
Copy link
Contributor

@karthikvt26 karthikvt26 commented Oct 19, 2018

Fix #562

Description

Adds helper functions to format/highlight sql response.

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 19, 2018

Review app available at: https://hge-ci-pull-819.herokuapp.com

@karthikvt26
Copy link
Contributor Author

karthikvt26 commented Oct 19, 2018

Query which can be used to test

mutation insertInformation {
  insert_table1(objects: [
    {
      name: "One"
    },
    {
      name: "Two"
    }
  ]) {
    affected_rows
  }
}

mutation insertTable2 {
  insert_table2(objects: [
    {
      table_1: 1
      desc: "Some description 1"
    }
    {
      table_1: 2
      desc: "Some description 2"
    }
  ]) {
    affected_rows
  }
}

query fetchTable1 {
  table1 {
    id
    name
    table2sBytable1 {
      id
    }
  }
  table2 {
    id
    desc
  }
}

query fetchTable2 {
  table2 {
    id
    desc
  }
}

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 19, 2018

Review app available at: https://hge-ci-pull-819.herokuapp.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 19, 2018

Review app available at: https://hge-ci-pull-819.herokuapp.com

@0x777 0x777 merged commit 0e56c98 into hasura:master Oct 19, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 19, 2018

Review app https://hge-ci-pull-819.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for EXPLAIN ANALYZE-ing generated SQL to help tweak perf with indices, etc.

4 participants

@karthikvt26 @hasura-bot @praveenweb @0x777