这是indexloc提供的服务，不要输入任何密码
Skip to content

set event trigger headers from console (close 523) #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 27, 2018
Merged

set event trigger headers from console (close 523) #812

merged 10 commits into from
Oct 27, 2018

Conversation

@paranoidsp
Copy link
Contributor

@paranoidsp paranoidsp commented Oct 19, 2018

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2018 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ karthikvt26
❌ Karthikeya Viswanath

Karthikeya Viswanath seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paranoidsp
Copy link
Contributor Author

paranoidsp commented Oct 19, 2018

Two pending things in this PR:

  • One issue with the default values and how they're handled in the form submission
  • Header name/value validation

Will discuss both issues with @karthikvt26 and sort them out.

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 19, 2018

Review app available at: https://hge-ci-pull-812.herokuapp.com

@shahidhk shahidhk added c/console Related to console s/do-not-merge Do not merge this pull request to master s/wip Status: This issue is a work in progress labels Oct 20, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 25, 2018

Review app available at: https://hge-ci-pull-812.herokuapp.com

1 similar comment
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 25, 2018

Review app available at: https://hge-ci-pull-812.herokuapp.com

karthikvt26
karthikvt26 approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@karthikvt26 karthikvt26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsandip its good to go. Can you test once?

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 25, 2018

Review app available at: https://hge-ci-pull-812.herokuapp.com

2 similar comments
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 25, 2018

Review app available at: https://hge-ci-pull-812.herokuapp.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 25, 2018

Review app available at: https://hge-ci-pull-812.herokuapp.com

dsandip
dsandip approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@dsandip dsandip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Ignoring the existing UI issue for now.

@praveenweb praveenweb added s/ok-to-merge Status: This pull request can be merged to master and removed s/do-not-merge Do not merge this pull request to master s/wip Status: This issue is a work in progress labels Oct 26, 2018
@shahidhk shahidhk merged commit 224042a into hasura:master Oct 27, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 27, 2018

Review app https://hge-ci-pull-812.herokuapp.com is deleted

@karthikvt26 karthikvt26 mentioned this pull request Dec 13, 2018
Closed
hasura-bot pushed a commit that referenced this pull request Jul 10, 2024
@danieljharvey @daniel-chambers @hasura-bot
Split ValueExpression (#812)
ab1d963 
### What
`ValueExpression` contained boolean expressions, and was used in places
where boolean expressions were not allowed.

### How
This creates a new type `ValueExpressionOrPredicate`, and uses it in the
places where boolean expressions are allowed.

---------

Co-authored-by: Daniel Chambers <daniel@hasura.io>
V3_GIT_ORIGIN_REV_ID: c0a07c5e0096aeb4369ca7d6b5147451d1ccd14d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsandip dsandip dsandip approved these changes

@karthikvt26 karthikvt26 karthikvt26 approved these changes

Assignees

No one assigned

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@paranoidsp @CLAassistant @hasura-bot @dsandip @karthikvt26 @shahidhk @praveenweb