这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented Oct 18, 2018

Description

Currently, composite relationship suggestions are not available in the console. This PR adds the support for the same.

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#284

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@arvi3411301 arvi3411301 added s/do-not-merge Do not merge this pull request to master c/console Related to console s/wip Status: This issue is a work in progress labels Oct 18, 2018
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-808.herokuapp.com

@arvi3411301
Copy link
Member Author

/heroku deploy

@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-808.herokuapp.com

@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-808.herokuapp.com

@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-808.herokuapp.com

upQuery.args.using = {
manual_configuration: {
remote_table: {
table: rTable,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the key should not be table. it should be name

@praveenweb praveenweb removed s/do-not-merge Do not merge this pull request to master s/wip Status: This issue is a work in progress labels Oct 27, 2018
@praveenweb praveenweb added the s/ok-to-merge Status: This pull request can be merged to master label Oct 27, 2018
@praveenweb praveenweb self-requested a review October 27, 2018 03:20
@praveenweb
Copy link
Member

@shahidhk - merge this.

@shahidhk shahidhk merged commit add2d40 into hasura:master Oct 27, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-808.herokuapp.com is deleted

@arvi3411301 arvi3411301 deleted the issue-284 branch January 3, 2019 11:02
hasura-bot pushed a commit that referenced this pull request Jul 9, 2024
<!-- The PR description should answer 2 (maybe 3) important questions:
-->

### What

We have a giant error file in `metadata-resolve`, and it's really
unclear what can go wrong where. Let's improve it in some small way.

<!-- What is this PR trying to accomplish (and why, if it's not
obvious)? -->

<!-- Consider: do we need to add a changelog entry? -->

### How

Move `GraphqlConfigError` to the `graphql_config` stage, and make that
stage only return that kind of error.

Functional no-op.

<!-- How is it trying to accomplish it (what are the implementation
steps)? -->

---------

Co-authored-by: Samir Talwar <samir.talwar@hasura.io>
V3_GIT_ORIGIN_REV_ID: 9aa58875a24d66e6945c9ead6434fedb124f1dd8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants