It seemed like there was an opportunity for a fix in the schema-parsers library here: https://github.com/hasura/graphql-engine-mono/blob/main/server/lib/schema-parsers/src/Hasura/GraphQL/Parser/Internal/Parser.hs#L189. However on closer inspection it seems more complicated than that.

Currently we collect together all the FieldParsers that are generated and group any duplicates by name and using them to show an errors. One solution could be to look at the sets of duplicates and decide if there's one we'd rather keep, removing the others. To do so though, we need to decide on a way to identify which is the "better" parser.

For example, if a user is tracking both authors and authors_by_pk tables, and then a new version of HGE adds the x_by_pk feature (pretend for a moment it's not already there).

Our first conflict will be between versions of the hasura_author_by_pk parser. One is from author, the other from author_by_pk. The parser that is named after the table should be more important, as we checked for conflicts before allowing HGE to track it. Therefore Hasura adding this new feature must be at fault, and we should prefer the parser that matches the table name.

(How could we do this? Currently we have MetadataObjId for looking at the source of FieldParsers, and although it does not disambiguate the ideas of "created from table" and "derived from table" it doesn't seem a stretch to add it.)

However, if we resolve the first conflict, then we have a second conflict between which version of update_hasura_author_by_pk wins - should it be the one from author or author_by_pk? This gets a little trickier to do automatically as they're both created by Hasura.

There are a few hacks like choosing the origin with the longer name, but that seems like it will come back to haunt us as another bug in the future.

server/bug: conflicts on tables that are already tracked should not cause the server to fail #8866

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions