这是indexloc提供的服务,不要输入任何密码
Skip to content

add dynamic connections docs #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 16, 2025
Merged

add dynamic connections docs #1029

merged 6 commits into from
Jul 16, 2025

Conversation

BenoitRanque
Copy link
Contributor

Description 📝

Quick Links 🚀

Assertion Tests 🤖

Users should understand postgres dynamic connections configuration
Users should be able to understand and follow the tutorial

Copy link

cloudflare-workers-and-pages bot commented Jul 15, 2025

Deploying ddn-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 922e975
Status: ✅  Deploy successful!
Preview URL: https://87b6de88.v3-docs-eny.pages.dev
Branch Preview URL: https://add-dynamic-postgres.v3-docs-eny.pages.dev

View logs

@hasura-bot
Copy link
Contributor

@BenoitRanque Thanks for your PR! I've assigned @robertjdominguez to review it.

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 15, 2025

DX: Assertion Testing

✅ Diff

The author's contribution in the PR clearly explains the new functionality provided by the dynamicSettings field. The addition of two modes (Named and Dynamic) with examples is beneficial for understanding how to set up dynamic connections. Security concerns are rightly highlighted, reminding users to apply proper security measures when using Dynamic mode.

✅ Integrated

The introduction of the dynamicSettings configuration integrates well with the existing documentation. It is placed appropriately within the configuration reference section. Furthermore, the new tutorial on Dynamic Connections is well-structured, properly explaining the setup process, prerequisites, and step-by-step guidance for testing. This integration with included examples should greatly enhance the usability for users looking to understand and implement dynamic connections with PostgreSQL.

@hasura-bot hasura-bot requested a review from danieljharvey July 15, 2025 21:34
@codedmart
Copy link
Contributor

Can we add a link to the dynamic connection page from the postgres index page /reference/connectors/postgresql/ -> here?

@codedmart
Copy link
Contributor

Or should this live under plugin tutorials? I know this is specific to postgres only right now.

Copy link
Collaborator

@robertjdominguez robertjdominguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so as not to block; please see the note below.

@BenoitRanque
Copy link
Contributor Author

Or should this live under plugin tutorials? I know this is specific to postgres only right now.

Dynamic connections specifically is a postgres feature.

We could add a tutorial for ndc level caching, which could live with the other plugins. But that would mean we would be suggesting two different plugins for caching. Are we happy to do that? They're technically different, do we have a preference for where we'd rather folks implement caching?

IMHO, we have a caching plugin already, so let's not muddy the waters.

@robertjdominguez robertjdominguez merged commit 35782a0 into main Jul 16, 2025
5 checks passed
@robertjdominguez robertjdominguez deleted the add_dynamic_postgres branch July 16, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants