fix partial introspection of qualified table names #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codedmart
reviewed
Feb 19, 2024
|
This is not a breaking change. Rather this should allow the connector to work correctly for users affected by this bug |
codedmart
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connector was recently modified to allow for qualified table names, after it became apparent the previous assumptions that all clickhouse tables would always live in the
defaultschema proved false.Those changes missed that we also relied on this assumption when introspecting filtered tables, that is only fetching introspection for specific tables.
This fix changes the assumption from "table names are arrays with a single string" to "table names are arrays with at least one string". We filter using the last string in the array.
Note, this behavior is still incorrect. We now ignore the qualified part of the table name, so when asked to introspect table
schema1.table1we would also return introspection result forschema2.table1We can probably fix that too if it's a problem?