Fixed methods of Spline2D.js and Spline3D.js in geom package #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e2D.js and Spline3D.js in geom package, new build
Owner
|
Thank you for this fix, as well as for the explanation. That is a tricky one to spot. Thanks again it is greatly appreciated! |
hapticdata
added a commit
that referenced
this pull request
Feb 7, 2015
Fixed methods of Spline2D.js and Spline3D.js in geom package
Author
|
No worries. You've done a great job porting this to JS, really useful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the
getEstimatedArcLengthandgetDecimatedVerticesmethods ofSpline2D.jsandSpline3D.js. The bug ingetEstimatedArcLengthwas that in the original Java thearcLenIndexarray is instantiated with a length (arcLenIndex = new float[vertices.size()];). As this isn't really possible in JS, the loop following the instantiation wasn't running at all. In addition, index 0 (arcLenIndex[0]) must always be set to 0 so that the calculations ingetDecimatedVerticeswork correctly. In the Java this is again a result of thearcLenIndexinstantiation as the loop which fills this array always begins at 1. There was also another small syntax error ingetDecimatedVerticeswhere theuniformarray is referenced as a property of the object rather than a local variable.