这是indexloc提供的服务，不要输入任何密码
Skip to content

Pr/1189 #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Pr/1189 #1275

wants to merge 4 commits into from

Conversation

padawan40
Copy link

@padawan40 padawan40 commented May 13, 2025 •
edited by sourcery-ai bot
Loading

Summary by Sourcery

Update the face_swapper pre-check to use the correct models directory, ensure its creation with permission error handling, and fix the model download URL to the direct Hugging Face link.

Bug Fixes:

  • Correct the Hugging Face model URL to use the resolve endpoint for direct download

Enhancements:

  • Switch pre_check to use models_dir instead of abs_dir
  • Create the models directory if missing and log permission errors

David Strouk and others added 4 commits May 4, 2025 16:59
Fix model download path and URL
b7e011f 
- Use models_dir instead of abs_dir for download path
- Create models directory if it doesn't exist
- Fix Hugging Face download URL by using /resolve/ instead of /blob/
@davidstrouk @sourcery-ai
Update modules/processors/frame/face_swapper.py
ae88412 
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@davidstrouk @sourcery-ai
Update modules/processors/frame/face_swapper.py
647c5f2 
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@padawan40
Create .DS_Store
677a4dd
@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented May 13, 2025 •
edited
Loading

Reviewer's Guide

The PR refines the face_swapper’s pre_check by redirecting downloads to the models directory, ensuring that directory exists with permission handling, and correcting the Hugging Face URL for direct downloads.

File-Level Changes

Change Details Files
Switched download target directory
  • Replaced abs_dir with models_dir for downloads
 modules/processors/frame/face_swapper.py
Ensured models directory exists with permission handling
  • Added os.makedirs with exist_ok=True
  • Wrapped creation in try/except to log OSError and return False on failure
 modules/processors/frame/face_swapper.py
Updated Hugging Face download URL
  • Replaced blob/main URL with resolve/main path for direct download
 modules/processors/frame/face_swapper.py

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed May 13, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @padawan40 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

modules/processors/frame/face_swapper.py
logging.error(f"Failed to create directory {download_directory_path} due to permission error: {e}")
return False

# Use the direct download URL from Hugging Face
conditional_download(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (bug_risk): Handle conditional_download failures

Capture conditional_download’s return value and return False on failure; otherwise pre_check returns True even if the download fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@padawan40 @davidstrouk