这是indexloc提供的服务，不要输入任何密码
Skip to content

Allowing only alert trigger type to have empty configuration #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Allowing only alert trigger type to have empty configuration #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions model/actions/trigger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@ func (a Trigger) Validate(ctx ValidatorContext) (response ValidateResponse) {
return response.Error(ctx, MsgTriggerTypeNotSupported, a.Type, TriggerTypes)
}

// This handles just type
if a.Periodic == nil && a.Webhook == nil && a.Block == nil && a.Transaction == nil && a.Alert == nil {
return response
}

switch a.Type {
case PeriodicType:
if a.Periodic == nil {
Expand All @@ -58,7 +53,7 @@ func (a Trigger) Validate(ctx ValidatorContext) (response ValidateResponse) {
return response.Merge(a.Transaction.Validate(ctx.With(a.Type)))
case AlertType:
if a.Alert == nil {
return response.Error(ctx, MsgTriggerTypeMismatch, a.Type)
return response
}
return response.Merge(a.Alert.Validate(ctx.With(a.Type)))
}
Expand Down