Set default video export to 24fps and 50 bitrate #6
Conversation
Sunwood-ai-labs
commented
Nov 15, 2025
- Set default video bitrate to 50 Mbps (previously 20 Mbps)
- Maintain default FPS at 24
- Disable automatic setting changes on video import
- Disable automatic setting adjustments during rendering
- Preserve user-configured export settings consistently
- Set default video bitrate to 50 Mbps (previously 20 Mbps) - Maintain default FPS at 24 - Disable automatic setting changes on video import - Disable automatic setting adjustments during rendering - Preserve user-configured export settings consistently
Summary of ChangesHello @Sunwood-ai-labs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the predictability and quality of video exports by updating the default video bitrate to 50 Mbps and, crucially, by preventing automatic modifications to user-configured export settings. This change ensures that once a user sets their desired export parameters, these settings are respected and consistently applied throughout the video import and rendering workflows, providing a more reliable and user-controlled experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🎀 雪村綾乃 のレビュー🎀 雪村綾乃のUXチェック
ここ映えてる！
ここダサくない？
まとめ
🎀 雪村綾乃： — 雪村綾乃 |
🦊 狐崎煌羽 のレビュー🦊 狐崎煌羽のエグゼクティブレビュー
厳しく見るポイント
実行判断
リーダーメモ
— 狐崎煌羽 |
🌿 鬼塚蓮司 のレビュー🌿 鬼塚蓮司のエンジニアリングレビュー
気に入ったところ
ここ工夫したらもっと良さげ
追加でチェックしたいこと
— 鬼塚蓮司 |
There was a problem hiding this comment.
Code Review
This pull request successfully updates the default video export bitrate to 50 Mbps and disables automatic adjustments of export settings, both on asset import and during rendering. The changes simplify the logic by removing the code responsible for these automatic adjustments, ensuring that user-configured settings are preserved. The implementation is clean and directly addresses the goals of the PR. I've left a couple of comments regarding a minor formatting issue and a suggestion to improve code clarity for future maintenance.
| const deriveExportSettingsFromAsset = (asset: Asset, current: ExportSettings): ExportSettings | undefined => { | ||
| let changed = false; | ||
| const next: ExportSettings = { ...current }; | ||
|
|
||
| const durationSeconds = sanitizeDurationSeconds(asset.duration); | ||
| if (typeof durationSeconds === "number" && Math.abs(durationSeconds - next.durationSeconds) > 0.0005) { | ||
| next.durationSeconds = durationSeconds; | ||
| changed = true; | ||
| } | ||
|
|
||
| if (asset.type === "video") { | ||
| const fps = sanitizeFrameRate(asset.fps); | ||
| if (typeof fps === "number") { | ||
| const roundedFps = Math.round(fps); | ||
| if (roundedFps !== next.fps) { | ||
| next.fps = roundedFps; | ||
| changed = true; | ||
| } | ||
| } | ||
|
|
||
| const videoBitrateMbps = deriveVideoBitrateMbps(asset.size, asset.duration); | ||
| if (typeof videoBitrateMbps === "number" && videoBitrateMbps !== next.videoBitrateMbps) { | ||
| next.videoBitrateMbps = videoBitrateMbps; | ||
| changed = true; | ||
| } | ||
| } | ||
|
|
||
| let audioBitrateKbps = sanitizeAudioBitrateKbps(asset.audioBitrateKbps); | ||
| if (audioBitrateKbps === undefined) { | ||
| audioBitrateKbps = deriveAudioBitrateKbps(asset.size, asset.duration); | ||
| } | ||
|
|
||
| if (typeof audioBitrateKbps === "number" && audioBitrateKbps !== next.audioBitrateKbps) { | ||
| next.audioBitrateKbps = audioBitrateKbps; | ||
| changed = true; | ||
| } | ||
|
|
||
| return changed ? next : undefined; | ||
| // Export settings are no longer automatically changed when importing videos | ||
| // to maintain user-configured default values | ||
| return undefined; | ||
| }; |
There was a problem hiding this comment.
While this change correctly disables auto-adjustment of export settings, the function name deriveExportSettingsFromAsset is now misleading because it no longer derives any settings. This can cause confusion for future developers. A follow-up refactoring to remove this function and its call site in assignAssetToCell would be ideal, as that code path is now effectively dead.
| } | ||
| // Use export settings as-is without auto-adjustment | ||
| const effectiveExportSettings = { ...exportSettings }; | ||
| let workingJob: RenderJob = { |
There was a problem hiding this comment.
This line has an indentation issue. The let workingJob declaration should be indented to align with the surrounding code inside the try block for correct formatting and readability.
| let workingJob: RenderJob = { | |
| let workingJob: RenderJob = { |