这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@lizkenyon
Copy link
Contributor

Description

Remove deprecated storefront_access_token positional parameter from Storefront client

This removes the deprecation introduced in PR #1302 (v14.1.0) in preparation for the v15.0.0 major release. Users must now use named parameters (private_token: or public_token:) instead of passing the token as a positional argument.

Updated Storefront client to raise ArgumentError when no token is provided, updated tests to use named parameters, and added breaking change documentation with migration examples.

Fixes #

Please, include a summary of what the PR is for:

  • What is the problem it is solving?
  • What is the context of these changes?
  • What is the impact of this PR?

How has this been tested?

Please, describe the tests that you ran to verify your changes.

Checklist:

  • My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the project documentation.
  • I have added a changelog line.

@lizkenyon lizkenyon requested a review from a team as a code owner October 14, 2025 19:26
@lizkenyon lizkenyon requested a review from sle-c October 14, 2025 19:26
…torefront client

This removes the deprecation introduced in PR #1302 (v14.1.0) in preparation for the v15.0.0 major release. Users must now use named parameters (private_token: or public_token:) instead of passing the token as a positional argument.

Updated Storefront client to raise ArgumentError when no token is provided, updated tests to use named parameters, and added breaking change documentation with migration examples.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@lizkenyon lizkenyon force-pushed the remove-passing-public-storefront-token branch from 3d67213 to 2fb80f2 Compare October 14, 2025 19:34
@lizkenyon lizkenyon merged commit 1301265 into main Oct 21, 2025
6 of 13 checks passed
@lizkenyon lizkenyon deleted the remove-passing-public-storefront-token branch October 21, 2025 17:20
lizkenyon added a commit that referenced this pull request Oct 21, 2025
…t-token

[Breaking] Remove deprecated storefront_access_token positional parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants