这是indexloc提供的服务，不要输入任何密码
Skip to content

Rename webhook handler file to match zeitwerk expectations #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

Rename webhook handler file to match zeitwerk expectations #1416

merged 1 commit into from
Oct 22, 2025

Conversation

@kirillplatonov
Copy link
Contributor

@kirillplatonov kirillplatonov commented Oct 22, 2025 •
edited
Loading

Description

Related to #1413

Zeitwerk check fails in main branch after removal of ShopifyAPI::Webhooks::Handler class.

➜  color-swatches git:(shopify-api-2025-10) ✗ rails zeitwerk:check
warning: parser/current is loading parser/ruby34, which recognizes 3.4.0-dev-compliant syntax, but you are running 3.4.5.
Please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
Hold on, I am eager loading the application.
bin/rails aborted!
NameError: uninitialized constant ShopifyAPI::Webhooks::Handler (NameError)

    @mod.const_get(@cname, false)
        ^^^^^^^^^^

Tasks: TOP => zeitwerk:check
(See full trace by running task with --trace)

I renamed file to match new handler name.

How has this been tested?

Tested by running bin/rails zeitwerk:check in shopify app.

Checklist:

  • My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the project documentation.
  • I have added a changelog line.

@kirillplatonov kirillplatonov requested a review from a team as a code owner October 22, 2025 15:36
lizkenyon
lizkenyon approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@lizkenyon lizkenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kirillplatonov Great catch!

I am going to make an issue for us to look into adding some automated checks that would have caught this.

@lizkenyon lizkenyon merged commit 1f8a4d3 into Shopify:main Oct 22, 2025
5 checks passed
@kirillplatonov
Copy link
Contributor Author

kirillplatonov commented Oct 22, 2025

Thank you @kirillplatonov Great catch!

I am going to make an issue for us to look into adding some automated checks that would have caught this.

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lizkenyon lizkenyon lizkenyon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kirillplatonov @lizkenyon