Add a way to unset an input property #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanahsmith
reviewed
Sep 6, 2017
| } | ||
|
|
||
| // Unsets the <%= escape_reserved_word(field.camelize_name) %> property so that it is not serialized | ||
| public void unset<%= field.classify_name %>() { |
Contributor
There was a problem hiding this comment.
It doesn't make sense to have this method for required fields, as is the case here.
Contributor
Author
There was a problem hiding this comment.
Makes sense so I fixed this.
This comment was on the optional field generator ☝️
Contributor
There was a problem hiding this comment.
originally the comment was for required fields, but github moved it after that got removed.
dylanahsmith
approved these changes
Sep 6, 2017
|
This looks good, but the test failures seem to be legitimate |
2 tasks
wesleyjellis
approved these changes
Sep 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
In this PR I am adding a way to unset properties so that they aren't serialized. This change is required because currently there is no way to tell a property to not serialize.
This is aimed to help consumers of this generator that were effected by the change #28 that used to reset their input types with
inputType.setProperty(null)so that they can useinputType.unsetProperty()instead.